655110 - Error in mailWindow1-aero.css

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

This two errors are in error console:

Warning: Expected color but found 'menuitem'.  Error in parsing value for 'background-color'.  Declaration dropped.
Source file: chrome://messenger/skin/mailWindow1.css
Line: 495
 ----------
Warning: Expected color but found 'menuitem'.  Error in parsing value for 'background-color'.  Declaration dropped.
Source file: chrome://messenger/skin/mailWindow1.css
Line: 476

Patch follows

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

I didn't removed only the two background-color: menuitem;, I made also this menupopups appears correct under Classic and High contrast themes. Before the background was fixed to white and the menuitems in submenus jumped.

Sorry to make more, than promised ;)

Comment 2

[Andreas Nilsson (:andreasn)]

It's good that you're taking care of the other issue too, but it makes this a bit harder to track, do you mind breaking the patch up in two and filing that as a separate bug. I promise to give that a review+ really, really fast :)

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Only error correction

Okay, this is only removing the styles which are causing the errors.

I gave no new style. So it looks like before, but only without errors in console.

Comment 4

[Richard Marti (:Paenglab)]

Filed the enhancement as Bug 658328

Comment 5

[Andreas Nilsson (:andreasn)]

Comment on attachment 533698 [details] [diff] [review]
Only error correction

Takes care of the issue!

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/bda8ab34845b