Remove WinCE code from docshell

RESOLVED FIXED in mozilla6

Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla6
All
Windows CE
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

WinCE & Windows Mobile code is being removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the /docshell/* & /uriloader/* parts of the removal:

http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/docshell/

http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/uriloader/
In creating the patch for this, I've come across:
> ifeq ($(OS_ARCH),WINNT WINCE)

Here:
http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/Makefile.in#183
and
http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/Makefile.in#208

...which looks broken to me.

However, if I go ahead and remove the WINCE string, that segment of code will now run under WINNT when it didn't before. 

Should I:
a) Remove the segment entirely, since it isn't being run at present.
b) Remove the WINCE string, thereby fixing that segment for WINNT and hope it's still needed?

Those lines were added back in CVS, with CVS blame saying:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&branch=1.61&root=/cvsroot&subdir=mozilla/uriloader/exthandler&command=DIFF_FRAMESET&rev1=1.60&rev2=1.61
...however there is no bug number mentioned in the commit message.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Classic. dougt landed a broken fix with r=dougt. :)

Honestly, I would just remove those sections since they haven't done anything useful in the past 6 years and nobody has noticed. The crud about cygwin make is outdated, we no longer support cygwin as a build environment.
Created attachment 530602 [details] [diff] [review]
Remove WinCE code from docshell (incl broken uriloader/exthandler/Makefile.in WINNT |ifeq|s)

Thanks Ted, have removed those sections entirely.

http://dev.philringnalda.com/tbpl/?tree=Try&rev=4a6a7b83227b
Attachment #530602 - Flags: review?(bzbarsky)
Comment on attachment 530602 [details] [diff] [review]
Remove WinCE code from docshell (incl broken uriloader/exthandler/Makefile.in WINNT |ifeq|s)

r=me
Attachment #530602 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/f20bf706d0b5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6

Updated

6 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.