655214 - accountName label is used on the place of server name label in Troubleshooting Information

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Masahiko Imanaka [:marsf]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.17) Gecko/20110420 Firefox/3.6.17
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:5.0a2) Gecko/20110505 Thunderbird/3.3a4pre

At the "Mail and News Accounts" section of Troubleshooting Information page, "aboutSupport.accountsName" entity is used on the place of server name.

The value of "aboutSupport.accountsName" is just "Name". This generic stiring is used on the label of account name and server name.

I want to separate them and localize to "アカウント名" (account name) and "サーバ名" (server name) in Japanese.  Actually, the target of them are different. Please don't reuse generic string to different target.

Reproducible: Always

Steps to Reproduce:
1. Open Troubleshooting Information page. (Help > Troubleshooting Information)
2. Click "Include account names" option to check.


Actual Results:  
The entity of account name label is used to server name label at "Mail and News Accounts" section.

Expected Results:  
Add "aboutSupport.accountsServerName" to aboutSupportMail.dtd and use it to server name label in the aboutSupport.xhtml.

Comment 1

[Ludovic Hirlimann [:Usul]]

Masahiko can you propose a patch ?

Comment 2

[Masahiko Imanaka [:marsf]]

Attachment: add accountsServerName

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 530564 [details] [diff] [review]
add accountsServerName

This doesn't really need UX review, and I'm going to steal the review.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 530564 [details] [diff] [review]
add accountsServerName

Looks great. Thanks for doing the patch. I've just landed it as well:

http://hg.mozilla.org/comm-central/rev/6f0e51f510aa

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Comment on attachment 530564 [details] [diff] [review] [review]
> add accountsServerName
> 
> Looks great. Thanks for doing the patch. I've just landed it as well:
> 
> http://hg.mozilla.org/comm-central/rev/6f0e51f510aa

Wrong url, it should have been this one: http://hg.mozilla.org/comm-central/rev/10cdb94a0d26