Closed Bug 655427 Opened 9 years ago Closed 9 years ago

make sharedIDs used by automation not depend on package name

Categories

(Core :: Widget: Android, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox5 --- fixed

People

(Reporter: blassey, Assigned: blassey)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #530784 - Flags: review?(mark.finkle)
Blocks: 654838
Attached patch alternate patch (obsolete) — Splinter Review
This patch is slightly bigger, but has the advantage that it does the right thing if anyone ever builds a non-Fennec Android app on the Mozilla platform.  (Same as attachment 530783 [details] [diff] [review] from bug 654838, but updated to include Aurora.)

I'd be fine either way on this, since non-Fennec Android apps are purely theoretical at this point.
Attached patch alternate patchSplinter Review
added a missing bit
Attachment #530786 - Attachment is obsolete: true
Attached patch patchSplinter Review
this keeps the existing behavior for any app other than fennec
Attachment #530784 - Attachment is obsolete: true
Attachment #530784 - Flags: review?(mark.finkle)
Attachment #530788 - Flags: review?(mark.finkle)
Comment on attachment 530788 [details] [diff] [review]
patch


>diff --git a/embedding/android/Makefile.in b/embedding/android/Makefile.in
>   -DANDROID_VERSION_CODE=$(ANDROID_VERSION_CODE) \
>   $(NULL)
> 
>+
>+
>+
> GARBAGE += \

No need to add the extra line breaks

r+ with the nit
Attachment #530788 - Flags: review?(mark.finkle) → review+
OS: Linux → Android
Hardware: x86_64 → All
Attachment #530788 - Flags: approval-mozilla-aurora?
Attachment #530788 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → blassey.bugs
You need to log in before you can comment on or make changes to this bug.