Note: There are a few cases of duplicates in user autocompletion which are being worked on.

make sharedIDs used by automation not depend on package name

RESOLVED FIXED

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

Trunk
All
Android
Points:
---

Firefox Tracking Flags

(firefox5 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Created attachment 530784 [details] [diff] [review]
patch
Attachment #530784 - Flags: review?(mark.finkle)
(Assignee)

Updated

6 years ago
Blocks: 654838
Created attachment 530786 [details] [diff] [review]
alternate patch

This patch is slightly bigger, but has the advantage that it does the right thing if anyone ever builds a non-Fennec Android app on the Mozilla platform.  (Same as attachment 530783 [details] [diff] [review] from bug 654838, but updated to include Aurora.)

I'd be fine either way on this, since non-Fennec Android apps are purely theoretical at this point.
Created attachment 530787 [details] [diff] [review]
alternate patch

added a missing bit
Attachment #530786 - Attachment is obsolete: true
Created attachment 530788 [details] [diff] [review]
patch

this keeps the existing behavior for any app other than fennec
Attachment #530784 - Attachment is obsolete: true
Attachment #530784 - Flags: review?(mark.finkle)
Attachment #530788 - Flags: review?(mark.finkle)
Comment on attachment 530788 [details] [diff] [review]
patch


>diff --git a/embedding/android/Makefile.in b/embedding/android/Makefile.in
>   -DANDROID_VERSION_CODE=$(ANDROID_VERSION_CODE) \
>   $(NULL)
> 
>+
>+
>+
> GARBAGE += \

No need to add the extra line breaks

r+ with the nit
Attachment #530788 - Flags: review?(mark.finkle) → review+
OS: Linux → Android
Hardware: x86_64 → All
(Assignee)

Updated

6 years ago
Attachment #530788 - Flags: approval-mozilla-aurora?
Attachment #530788 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
pushed http://hg.mozilla.org/mozilla-central/rev/993a4122bacf and http://hg.mozilla.org/releases/mozilla-aurora/rev/605a0e626645
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
status-firefox5: --- → fixed

Updated

6 years ago
Assignee: nobody → blassey.bugs
You need to log in before you can comment on or make changes to this bug.