Closed Bug 654838 Opened 9 years ago Closed 9 years ago

Create a unique branding for Fennec beta

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(firefox5 fixed, fennec5+)

VERIFIED FIXED
Tracking Status
firefox5 --- fixed
fennec 5+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(4 files, 2 obsolete files)

We want to be able to install the beta along side the final release (and aurora and nightly) so we need a separate Android package id for beta releases.
Attached patch wip (obsolete) — Splinter Review
I think this should work, but I need to test
Assignee: nobody → mark.finkle
Attachment #530151 - Flags: feedback?(blassey.bugs)
Comment on attachment 530151 [details] [diff] [review]
wip

I don't want to have the . in there since this is our java package name, which would make the beta a sub package of our release package name. I suggest org.mozilla.firefoxBeta
Attachment #530151 - Flags: feedback?(blassey.bugs) → feedback-
We are making a full branding for Firefox Mobile beta
Summary: Create a unique Android package ID for Fennec beta → Create a unique branding for Fennec beta
Attached patch patchSplinter Review
This adds a full branding folder, changes the appid to "org.mozilla.firefox_beta" and changes "Firefox" -> "Firefox Beta" in the branding strings.

We still need the images to be updated
Attachment #530151 - Attachment is obsolete: true
Attachment #530345 - Flags: review?(blassey.bugs)
Blocks: 652652
As a side note, by making the changes as proposed, the SUTAgent should work without modification. So test automation should be unaffected.
Comment on attachment 530345 [details] [diff] [review]
patch

Review of attachment 530345 [details] [diff] [review]:
-----------------------------------------------------------------

r=blassey
Attachment #530345 - Flags: review?(blassey.bugs) → review+
tracking-fennec: --- → ?
OS: Linux → All
Hardware: x86 → All
I missed the change to the shared_id. This needs to stay the same even though the packagename is changing. Otherwise a new content provider will need to be created. In the meantime automation will be horked.
Note that if beta builds have the same sharedUserId as release builds, then they will need to be signed with the release signing certificate.  Otherwise they will not be installable at the same time as the release builds.

(Past beta releases *were* signed with the release certificate.  As long as we do the same for future beta builds, giving them the same sharedUserId should not cause any problems.)
Is this what you need, Bob?
Attachment #530783 - Flags: review?(blassey.bugs)
Attachment #530783 - Flags: feedback?(bmoss)
Check to make sure you don't need to update the js/configure.in too. Those are supposed to be in sync.
Comment on attachment 530783 [details] [diff] [review]
part 2: make beta sharedUserId same as release

nothing particularly wrong about this except that we'd have to make a similar change for auora. I've got a patch in bug 655427 that handles both
Attachment #530783 - Flags: review?(blassey.bugs) → review-
This variable (like ANDROID_PACKAGE_NAME) is not used in js, so does not need to appear in js/configure.
(In reply to comment #11)
> Check to make sure you don't need to update the js/src/configure.in too. Those
> are supposed to be in sync.
there's no requirement for configure.in and js/configure.in to be in sync (and they're not). Its config/* and js/src/config/* that need to be in sync
Basically the Content Providers for the mobile automation can handle two sharedID's org.mozilla.fennec.sharedID and org.mozilla.firefox.sharedID, and the agent determines which content provider it uses based upon a "contains" comparison of the fully qualified path (ex: /data/data/[packagename]/... looking for "org.mozilla.firefox" so the proposed "org.mozilla.firefox_beta" works just fine) the same would be true for fennec variants. Let me know if I can clarify here. No insult intended but I like blassey's patch in 655427 it seems pretty straightforward.
This may be a topic for another bug, but why don't we build the agent (and/or content provider) when we build fennec so it can be signed with the same cert as fennec every time?
Attached patch part 3Splinter Review
While testing the beta branding, we found the MOZ_APP_DISPLAYNAME needed to be quoted in configure.sh and then again when apssed to the preprocessor to make AndroidManifest.xml

With this patch we are fully function on the device and can run side by side with release, aurora and nightly
Attachment #531531 - Flags: review?(blassey.bugs)
Comment on attachment 531531 [details] [diff] [review]
part 3

Review of attachment 531531 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #531531 - Flags: review?(blassey.bugs) → review+
Comment on attachment 530345 [details] [diff] [review]
patch

needed for the upcoming beta builds
Attachment #530345 - Flags: approval-mozilla-aurora+
Attachment #530345 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
Comment on attachment 531531 [details] [diff] [review]
part 3

needed for the upcoming beta builds
Attachment #531531 - Flags: approval-mozilla-aurora?
Attachment #531531 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #530345 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: ? → 5+
This patch adds the new launcher logos/icons from bug 652652

Example of how it looks here:
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-beta-recent.png
Attachment #531941 - Flags: review?(blassey.bugs)
Comment on attachment 531941 [details] [diff] [review]
patch 4 - new logos with 'beta' banner

needed for beta ASAP
Attachment #531941 - Flags: approval-mozilla-aurora+
Attachment #530783 - Attachment is obsolete: true
Attachment #530783 - Flags: feedback?(bmoss)
Attachment #531941 - Flags: review?(blassey.bugs) → review+
Please land for Aurora by Monday May 16 or the approval will potentially be lost.  Please mark as status-firefox5 fixed when you do.
Landed in mozilla-central (Firefox 6) and Aurora (Firefox 5):
http://hg.mozilla.org/mozilla-central/rev/9a7b966ab0b6
http://hg.mozilla.org/mozilla-aurora/rev/ad45139f4d29
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attached patch patch 5 - maemoSplinter Review
This patch fixes Maemo. The main problem was the handling of MOZ_APP_DISPLAYNAME. The package manifest, and other places, broke due to the space. The installer makefile now quotes MOZ_APP_DISPLAYNAME to avoid the breakage.

The maemo image assests did not have the beta banner we added to the android assets. I replaced the images with the beta banner-ized images.

I built, packaged the deb, and installed on my N900 successfully with this patch
Attachment #532111 - Flags: review?(blassey.bugs)
Attachment #532111 - Flags: review?(blassey.bugs) → review+
Attachment #532111 - Flags: approval-mozilla-aurora?
Attachment #532111 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Need to wait for a beta build in order to verify.
You can try verifying using the test beta build:
http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/5.0b1-candidates/build2/

It was built from mozilla-aurora, so it is versioned as 5.0a2, but it should have the beta branding.
Verified fixed on: Mozilla /5.0 (Android;Linux armv7l;rv:5.0) Gecko/20110517 Firefox/5.0 Fennec/5.0
Device: LG Optimus 2x
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.