655522 - Severity values no longer defined in fields.html

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Stephanie Daugherty [:sdaugherty]]

https://bugzilla.mozilla.org/page.cgi?id=fields.html#severity no longer lists the meanings of the possible values of Severity after the upgrade.

Comment 1

[Alex Lakatos[:AlexLakatos]]

The link points to the id #severity that is now changed to #bug_severity. The links should be updated.

Comment 2

[Frédéric Buclin]

Where did you find this link? If you typed it yourself in the address bar, then this bug is invalid. If it appears somewhere in the UI, then it should be fixed.

Comment 3

[Ed Morley [:emorley]]

Side issue, but related:
Clicking the "Status" link at the top of a BMO bug report, links to:
https://bugzilla.mozilla.org/page.cgi?id=fields.html#status
...which mentions things like "IN_PROGRESS"; rather than "ASSIGNED" etc

Comment 4

[Stephanie Daugherty [:sdaugherty]]

Frédéric: It's linked to from 
https://developer.mozilla.org/en/What_to_do_and_what_not_to_do_in_Bugzilla 

Regardless, fields.html no longer has the Mozilla-specific definitions of severity levels, which were there before the upgrade.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> Regardless, fields.html no longer has the Mozilla-specific definitions of
> severity levels, which were there before the upgrade.

Right, I have been confused by comment 1, and I thought you were complaining about the link. :) We indeed removed the description for the bug severities in Bugzilla 4.0. The link being broken should be reported in a separate bug, though.

Comment 6

[David Lawrence [:dkl]]

Attachment: Patch to port text from 3.6 fields help page to 4.0 (v1)

Here is a patch that updates the 4.0 page adding in the old text for each of the statuses, resolutions and other fields. I have to edit page/fields.html.tmpl directly for the status/resolution table changes but for the other fields, I was able to hook in and add the new text to the BMO extension.

dkl

Comment 7

[:glob ✱]

Comment on attachment 531461 [details] [diff] [review]
Patch to port text from 3.6 fields help page to 4.0 (v1)

Review of attachment 531461 [details] [diff] [review]:
-----------------------------------------------------------------

> extensions/BMO/template/en/default/hook/bug/field-help-end.none.tmpl

this file needs a license header.

::: extensions/BMO/template/en/default/hook/bug/field-help-end.none.tmpl
@@ +8,5 @@
> +  [% filtered_severity_enhancement = display_value("bug_severity", "enhancement") FILTER html %]
> +
> +  [% filtered_platform_all = display_value("rep_platform", "All") FILTER html %]
> +  [% filtered_platform_mac = display_value("rep_platform", "Macintosh") FILTER html %]
> +  [% filtered_platform_pc  = display_value("rep_platform", "PC") FILTER html %]

our platform field doesn't contain "macintosh" or "pc".

@@ +75,5 @@
> +       <ul>
> +         <li>$filtered_opsys_all (happens on all operating systems; cross-platform ${terms.bug})</li>
> +         <li>Windows</li>
> +         <li>Mac OS</li>
> +         <li>Linux</li>

our op_sys field doesn't contain "windows" or "mac os".  we don't have a generic windows op_sys, and we have "mac os x" for mac.

Comment 8

[David Lawrence [:dkl]]

Attachment: Patch to port text from 3.6 fields help page to 4.0 (v2)

Thanks for the review and good catches. Thats what I get for porting the text over word for word without sanity checking the old wording. Here is new version that has the values updated to today's values.

dkl

Comment 9

[David Lawrence [:dkl]]

Attachment: Patch to port text from 3.6 fields help page to 4.0 (v3)

Ugh, forgot to add the fields-help-end template to the diff. Here it is.

dkl

Comment 10

[:glob ✱]

Comment on attachment 531645 [details] [diff] [review]
Patch to port text from 3.6 fields help page to 4.0 (v3)

r=glob

Comment 11

[David Lawrence [:dkl]]

Thanks glob. Will be in the next code update (maybe tomorrow).

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/BMO/Extension.pm
modified template/en/default/pages/fields.html.tmpl
added extensions/BMO/template/en/default/hook/bug/field-help-end.none.tmpl
Committed revision 7682.

dkl

Comment 12

[Stephanie Daugherty [:sdaugherty]]

Thanks for fixing this, I see it on the live bmo site now.

Comment 13

[Wayne Mery (:wsmwk)]

something has regressed. The description is now a rather non-descript ...

 Severity
    How severe the bug is, or whether it's an enhancement.

Comment 14

[Wayne Mery (:wsmwk)]

I couldn't find any bug reports that describe changing the description after this bug was fixed.

Comment 15

[David Lawrence [:dkl]]

Yeah I have verified this is now a problem. Recently upstream in stable version 4.0 changed some things around to allow quick loading of certain templates. This in turn broke our customizations of the fields help page. I am investigating a solution now.

dkl

Comment 16

[David Lawrence [:dkl]]

Committed fix and will be in the next code update soon.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/BMO/Extension.pm
modified extensions/BMO/template/en/default/hook/bug/field-help-end.none.tmpl
Committed revision 7833.

dkl