Closed Bug 655701 Opened 10 years ago Closed 10 years ago

Remove test dependencies on the html5.parser.enable pref

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: hsivonen, Assigned: hsivonen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In order to get rid of the pref itself, we should get rid of all tests that assume that the pref exists.

ted, in reference to needing to remove these also due to universalXPConnect removal, do you already happen to have a patch for this?
No, it was just on the list of things that needed to be dealt with, I hadn't done anything about it.
Blocks: 462483
OK.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Comment on attachment 531042 [details] [diff] [review]
Remove html5.parser.enable deps from the tests

Looks ok on try.
Attachment #531042 - Flags: review?(ted.mielczarek)
Comment on attachment 531042 [details] [diff] [review]
Remove html5.parser.enable deps from the tests

Review of attachment 531042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me

::: parser/htmlparser/tests/mochitest/test_compatmode.html
@@ +63,4 @@
>  function test(mode,i){
>    is(mode,doctypes[i],doctypes[i+1]);
>    if (i == doctypes.length - 2) {
> +    finishTest();

This could just become SimpleTest.finish() and remove the finishTest function. Doesn't matter all that much though.
Attachment #531042 - Flags: review?(ted.mielczarek) → review+
(In reply to comment #5)
> Looks good, r=me

Thanks.

> This could just become SimpleTest.finish() and remove the finishTest
> function. Doesn't matter all that much though.

Landed with this changed.

http://hg.mozilla.org/mozilla-central/rev/63fe82a5f142
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.