Remove final XP_MAC remnants

RESOLVED FIXED in mozilla6

Status

()

Core
General
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla6
PowerPC
Mac System 9.x
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Bug 281889 removed most of the XP_MAC (ie Mac Classic) code, but there is some still left to do.

Bug 480745 is already covering the /security/manager/ parts, which leaves the rest of:

http://mxr.mozilla.org/mozilla-central/search?string=XP_MAC&case=1&find=&findi=&filter=XP_MAC\b&hitlimit=&tree=mozilla-central
(Assignee)

Comment 1

6 years ago
Created attachment 531086 [details] [diff] [review]
Remove final XP_MAC remnants

http://dev.philringnalda.com/tbpl/?tree=Try&rev=b646f3f1b8dc
(Assignee)

Updated

6 years ago
Attachment #531086 - Flags: review?(joshmoz)
(Assignee)

Comment 2

6 years ago
Meant to add, I deliberately omitted the activex/src/pluginhostctrl/pluginsdk_include/ instances, since it seems to manually set XP_MAC even on XP_MACOSX, since it checks |ifdef macintosh|, which afaik is defined on OS X too:
http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/pluginhostctrl/pluginsdk_include/npapi.h#20
NSS part is being taken care in bug 480745
(Assignee)

Comment 4

6 years ago
Yup, I deliberately omitted those parts for that reason :-) (Comment 0)

Updated

6 years ago
Attachment #531086 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 531290 [details] [diff] [review]
Remove final XP_MAC remnants

Only change is updated commit message to include r=josh
Carrying forwards r+
Attachment #531086 - Attachment is obsolete: true
Attachment #531290 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
http://hg.mozilla.org/mozilla-central/rev/b68afa9fd243
You need to log in before you can comment on or make changes to this bug.