Last Comment Bug 655756 - Remove final XP_MAC remnants
: Remove final XP_MAC remnants
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: PowerPC Mac System 9.x
: -- minor (vote)
: mozilla6
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: 281889
  Show dependency treegraph
 
Reported: 2011-05-09 10:16 PDT by Ed Morley [:emorley]
Modified: 2011-05-10 13:31 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove final XP_MAC remnants (71.06 KB, patch)
2011-05-09 10:53 PDT, Ed Morley [:emorley]
jaas: review+
Details | Diff | Splinter Review
Remove final XP_MAC remnants (71.07 KB, patch)
2011-05-10 04:05 PDT, Ed Morley [:emorley]
emorley: review+
Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2011-05-09 10:16:41 PDT
Bug 281889 removed most of the XP_MAC (ie Mac Classic) code, but there is some still left to do.

Bug 480745 is already covering the /security/manager/ parts, which leaves the rest of:

http://mxr.mozilla.org/mozilla-central/search?string=XP_MAC&case=1&find=&findi=&filter=XP_MAC\b&hitlimit=&tree=mozilla-central
Comment 1 Ed Morley [:emorley] 2011-05-09 10:53:38 PDT
Created attachment 531086 [details] [diff] [review]
Remove final XP_MAC remnants

http://dev.philringnalda.com/tbpl/?tree=Try&rev=b646f3f1b8dc
Comment 2 Ed Morley [:emorley] 2011-05-09 11:09:31 PDT
Meant to add, I deliberately omitted the activex/src/pluginhostctrl/pluginsdk_include/ instances, since it seems to manually set XP_MAC even on XP_MACOSX, since it checks |ifdef macintosh|, which afaik is defined on OS X too:
http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/pluginhostctrl/pluginsdk_include/npapi.h#20
Comment 3 Ludovic Hirlimann [:Usul] 2011-05-09 11:39:20 PDT
NSS part is being taken care in bug 480745
Comment 4 Ed Morley [:emorley] 2011-05-09 11:41:14 PDT
Yup, I deliberately omitted those parts for that reason :-) (Comment 0)
Comment 5 Ed Morley [:emorley] 2011-05-10 04:05:23 PDT
Created attachment 531290 [details] [diff] [review]
Remove final XP_MAC remnants

Only change is updated commit message to include r=josh
Carrying forwards r+
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2011-05-10 13:31:48 PDT
http://hg.mozilla.org/mozilla-central/rev/b68afa9fd243

Note You need to log in before you can comment on or make changes to this bug.