Closed Bug 655756 Opened 12 years ago Closed 12 years ago

Remove final XP_MAC remnants

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
PowerPC
Mac System 9.x
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla6

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove final XP_MAC remnants
71.07 KB, patch
emorley
: review+
Details | Diff | Splinter Review 
Bug 281889 removed most of the XP_MAC (ie Mac Classic) code, but there is some still left to do.

Bug 480745 is already covering the /security/manager/ parts, which leaves the rest of:

http://mxr.mozilla.org/mozilla-central/search?string=XP_MAC&case=1&find=&findi=&filter=XP_MAC\b&hitlimit=&tree=mozilla-central
Attachment #531086 - Flags: review?(joshmoz)
Meant to add, I deliberately omitted the activex/src/pluginhostctrl/pluginsdk_include/ instances, since it seems to manually set XP_MAC even on XP_MACOSX, since it checks |ifdef macintosh|, which afaik is defined on OS X too:
http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/pluginhostctrl/pluginsdk_include/npapi.h#20
NSS part is being taken care in bug 480745
Yup, I deliberately omitted those parts for that reason :-) (Comment 0)
Attachment #531086 - Flags: review?(joshmoz) → review+
Only change is updated commit message to include r=josh
Carrying forwards r+
Attachment #531086 - Attachment is obsolete: true
Attachment #531290 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.