655852 - Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Aurora Branch:
Mozilla/5.0 (Android; Linux armv71; rv5.0a2) Gecko/20110509 Firefox/5.0a2 Fennec/5.0a2
Device: Thunderbolt
OS: Android 2.2

1. go to people.mozilla.com/~nhirata/html_tp/formsninput.html
2. click in the first text field
3. type in anything, but keep typing until you get past the border of the text field

Expected: the text will scroll and the cursor will be at the end of the text field
Actual: the text starts disappearing from the left side and you can't see what you're typing

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Does not seem to happen in Nightly trunk

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> Does not seem to happen in Nightly trunk

See bug 656272

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

is this android only? or IME only?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Seems to be ok for 3/16;3/17 breaks

Mozilla/5.0 (Android; Linux armv71; rv2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre
Device: Thunderbolt
OS: Android 2.2

steps to reproduce changes slightly: 
1. go to reader.google.com
2. in the login field type stuff to go past the field length
3. in the password field type stuff to go past the field length
4. go back to the login field and type stuff to go past the field length.

Expected: the text will scroll and the cursor will be at the end of the text field
Actual: the text starts disappearing from the left side and you can't see what you're typing

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

blassey: nhirata: if you long press the user name field (for bug 655852) and select all and then copy
[11:07am] blassey: does that give you the full text?
[11:08am] nhirata: let me check
[11:10am] nhirata: it gives the full text

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

blassey: does it reproduce on desktop?
[11:14am] nhirata: it reproduces on the mac version of fennec.
[11:14am] nhirata: today's nightly

Screenshot attached

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screen recording

Slight adjustment to the steps.  You have to position the cursor past the boundary of the field in order to see the behavior.  see screen recording.

Comment 9

[Benjamin Stover (:stechz)]

This does happen in nightly trunk (you need to tap and pan the scrollbox first), and I think this would have been an issue ever since panning overflow elements landed in bug 618975. Mark and I have confirmed this is an issue on 4.0.1, though for some reason it is harder to reproduce.

Comment 10

[Benjamin Stover (:stechz)]

The reason this happens is that asynchronous scrolling requires us to watch for content process scroll events for anything we set a displayport on. We need to update the content views to reflect the new scroll position. This is actually a problem for anything (iframes, divs, etc.) but it's especially noticable on input boxes because typing does generate scrolls.

For now, the easiest fix is to stop setting displayports for text elements.

Comment 11

[Benjamin Stover (:stechz)]

Attachment: Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

Comment 12

[Matt Brubeck (:mbrubeck)]

Comment on attachment 532375 [details] [diff] [review]
Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

>+        let binding = element.ownerDocument.getBindingParent(element);
>+        if (binding && binding.querySelectorAll("input"))
>+          break;

I don't think you want querySelectorAll here, since that will include descendants of the parent element.

In content.js we use this code to test for text fields and text areas:

if ((elem instanceof Ci.nsIDOMHTMLInputElement && elem.mozIsTextField(false))
    || elem instanceof Ci.nsIDOMHTMLTextAreaElement)

Comment 13

[Matt Brubeck (:mbrubeck)]

This patch intentionally removes the ability to pan text fields by dragging them.  (This ability was added in bug 618975.)  If we land this, we'll need a followup to re-enable this capability with the bugs fixed.

Comment 15

[Benjamin Stover (:stechz)]

Attachment: Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

Not sure if this is more satisfactory, but I tried something different and
checked if the bit flag is set. This looks similar to what FrameLayerBuilder
does in StoreNewDisplayItemData so I thought it might work. Let me know if I
need to do this as per your suggestion.

Comment 16

[Benjamin Stover (:stechz)]

Comment on attachment 533094 [details] [diff] [review]
Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

Messed up, sorry.

Comment 17

[Benjamin Stover (:stechz)]

Attachment: Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

Comment 18

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mozilla-central/rev/659100d22758

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110519 Firefox/6.0a1 Fennec/6.0a1
Device: Droid 2 
OS: Android 2.2

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110519 Firefox/6.0a1 Fennec/6.0a1
Device: Thunderbolt
OS: Android 2.2

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 533098 [details] [diff] [review]
Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

Approving this but it sure would be nice to have someone from mobile in these meetings doing the risk analysis part.

Comment 21

[Asa Dotzler [:asa]]

Comment on attachment 533098 [details] [diff] [review]
Typing past the boundaries of the textbox will start clearing the beginning characters, instead of scrolling

Please land this change on both Aurora and Beta. (In the future, getting changes in during Aurora will save you this extra step.)

Comment 22

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/releases/mozilla-beta/rev/ce9186dbb048