655857 - Contribution sources simplification

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Justin Scott [:fligtar]]

In a given day we see these sources:

+----------------------------+----------+
| source                     | count(*) |
+----------------------------+----------+
|                            |       19 | 
| addon-detail               |       32 | 
| addon-detail-version       |        1 | 
| addondetail                |        9 | 
| api                        |       14 | 
| developers                 |       17 | 
| homepagebrowse             |        1 | 
| homepagepromo              |        4 | 
| meetthedeveloper_roadblock |        1 | 
| recommended                |        1 | 
| search                     |        1 | 
+----------------------------+----------+

Many of those aren't valid contribution sources, but because the download source trickles through to the roadblock/post-install page, the contribution source is counted as the download source. Additionally, lots of these sources were renamed in zamboni which makes it nearly impossible to do anything useful with the data.

These should be the only contribution sources:
addon-detail (made directly from the details page)
roadblock (made from the roadblock page)
post-download (made from the post-download page)
meet-developers (made from the meet the developers page)
standalone (made from the standalone /about or /installed page)
api (made from the contribute page with src=api from the add-ons manager)

Comment 1

[Wil Clouser [:clouserw]]

-> andym to investigate.

Comment 2

[Andy McKay]

What should I do with the following sources:

direct (made from the home or extensions page)
recommended 
search

Conflate with one of the above?

Comment 3

[Justin Scott [:fligtar]]

They'll be going away in the new designs, but for now we can call them browse or listing or something.

Comment 4

[Andy McKay]

I'm not sure where the "standalone /about or /installed pages are", wonder if they still exist.

"/en-US/firefox/addon/adblock-plus/about" redirects to "/en-US/firefox/addon/adblock-plus/contribute/installed/"

Comment 5

[Andy McKay]

Changes:

discovery-personalrec > api
homepagepromo > browse
addon-detail-version > addon-detail
direct > browse
addondetail > addon-detail
developers > meet-developers
meet-the-developer-post-install > post-download
meetthedeveloper_roadblock > roadblock
recommended > browse
search > browse

https://github.com/jbalogh/zamboni/commit/508d5daae

Comment 6

[krupa raj[:krupa]]

STR:
1. Load https://addons-next.allizom.org/z/en-US/firefox/?browse=featured
2. Click directly on the contribute link for one of the featured add-ons

expected behavior:
'direct' is not one of the src attributes for contribution 

observed behavior:
https://addons-next.allizom.org/z/en-US/firefox/addon/tab-mix-plus/contribute/?src=direct&type=suggested loads

Comment 7

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/f98d45e05863ab65d75b20588385c84337f1b8c6

Comment 8

[krupa raj[:krupa]]

STR:
1. Load https://addons-next.allizom.org/en-US/firefox/addon/foxyproxy-standard/versions/
2. Click on the 'Continue to Download' button
3. At this point, src = version-history (https://addons-next.allizom.org/en-US/firefox/addon/foxyproxy-standard/contribute/roadblock/?src=version-history&version=2.22.6)
4. Hover on the 'contribute' button. Notice that the src is changed to 'roadblock'
5. Make a contribution and see the src attribute in GET request

expected behavior:
src=roadblock is retained

observed behavior:
src=roadblock is replaced by source=version-history


Same behavior is seen for add-on with contrib-roadblock in 
* Collections detail page
* User profile page
* Creatured page

Comment 9

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/8b50ae664ce228bd98f717471e3c7154b181bdbf

Comment 10

[krupa raj[:krupa]]

Note that Discovery pane does not have contributions enabled. So it is not possible to check for discovery-personalrec > api.

addon-detail-version > addon-detail cannot be verified since the src always get changed to 'roadblock'

verified the following:
homepagepromo > browse
direct > browse
addondetail > addon-detail
developers > meet-developers
meet-the-developer-post-install > post-download
meetthedeveloper_roadblock > roadblock
recommended > browse
search > browse

Comment 11

[Justin Scott [:fligtar]]

Thanks. These are showing up nicely. I still see a few "direct" but not for any successful transactions, so maybe just an old link. There are, however, quite a few successful transactions that have no source.