655875 - Language switcher doesn't know about the current locale

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Staś Małolepszy :stas]

For context, see bug 647376, bug 652912 and bug 655305.

It looks like LANGUAGE_CODE doesn't work in the templates.  Consequently, the current locale name is not displayed when the lang chooser is closed, and it's not highlighted when it's open.

Comment 1

[Laura Mesa [:lmesa] [:lvmesa]]

Is this a tbg or moz bug?

Comment 2

[Austin King [:ozten]]

Updated use of LANGUAGE_CODE to LANG.

https://github.com/mozilla/markup/commit/ebe1b281f77232c343e20624fc1087a3baa1760c

Found another issue... chlocale helper doesn't work, since it doesn't understand our new setup.

I've made the switcher hardcode to /<locale> instead of taking the current url and fixing it up to the new locale. It' will be a bit of work to get this working with a chlocale like helper.

Comment 3

[Staś Małolepszy :stas]

Thanks Austin!(In reply to comment #2)

> Found another issue... chlocale helper doesn't work, since it doesn't
> understand our new setup.
> 
> I've made the switcher hardcode to /<locale> instead of taking the current
> url and fixing it up to the new locale. It' will be a bit of work to get
> this working with a chlocale like helper.

I filed bug 656470 to remember about this.

Thanks for the fix, Austin.