655885 - 'Timeout exceeded for waitForElement ID: getMeOutButton' in testSafeBrowsingWarningPages.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

testSecurity/testSafeBrowsingWarningPage has been failing since May 5th across all platforms for Firefox 6.0a1. Unfortunately, due to bug 650646, we are unable to determine the exact nature of this failure.

I'll need to do some investigation before we can clearly state the bug.

Comment 1

[u279076]

I'm not completely sure what the failure point is yet (seems to be near the end of the test -- after clicking the Ignore Warning button on the notification bar). However, I'm noticing a seemingly frequent occurrence of the attack page showing without the warning page displaying (even when the test first starts).

I'm going to write a minimized tests which repeatedly tries to load the page.

Comment 2

[u279076]

Attachment: Minimized test

Henrik, here is a minimized test.  To test run:

mozmill -b <build> -t <mozmill-tests>/tests/functional/testSecurity/testSafeBrowsingWarningPages_min.js

My experience shows that the warning page appears sometimes on first launch but not all the time. Once the warning page appears once, it appears always. You'll have to rerun the test if the first page load is the warning page. It does reproduce fairly easily though.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 531226 [details] [diff] [review]
Minimized test

This failure has been started on May 5th. So I really wonder if you can constantly reproduce it on a Nightly build from May 4th. It kinda smells like a regression or expected change in Firefox.

Comment 4

[u279076]

I'm able to trigger the failure on the 2011-05-04 Nightly build. That said, I can only trigger this failure through Mozmill (ie. the warning page ALWAYS displays if I manually type the URL and try to load the attack page).

I'll have to work further to find a regression range.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's clear now what the failure is since the fix for Mozmill has been landed:

Timeout exceeded for waitForElement ID: getMeOutButton

Has the button been renamed?

Comment 6

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13386881

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Anthony, can we please make sure to get this issue investigated soon? We have to be sure that this is not a regression in Firefox. Thanks.

Comment 8

[Aaron Train [:aaronmt]]

These related test failures are caused by bug 468313, with http://hg.mozilla.org/mozilla-central/rev/79497dd8d244, begining on May 5th with http://hg.mozilla.org/mozilla-central/rev/31879b88cc82

Comment 9

[u279076]

Thanks Aaron, this looks like an intentional regression. In other words we will need to update these tests. I've commented on bug 468313 to get clarification from the developers on expected behaviour.

Comment 10

[u279076]

Attachment: Patch v1.0

Fixes failures in both Safe Browsing tests by using UtilsAPI.removePermission().

NOTE: This will need to be checked in to both default and mozilla-aurora.
NOTE: Check-in of this patch will fix bug 655884 as well.

Comment 11

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 535747 [details] [diff] [review]
Patch v1.0

Per discussion, need to make sure the permission's reset no matter what. Simplest bet is we add it to teardown too.

Comment 12

[u279076]

Attachment: Patch v1.1 [checked-in]

Added removePermissions() call to the teardownModule() as well.

Comment 13

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 535751 [details] [diff] [review]
Patch v1.1 [checked-in]

Looks good! If you can go ahead and land it, that'd be appreciated. r+

Comment 14

[u279076]

Comment on attachment 535751 [details] [diff] [review]
Patch v1.1 [checked-in]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/6189c0770111 [default]
http://hg.mozilla.org/qa/mozmill-tests/rev/8d1727127611 [mozilla-aurora]