Closed
Bug 655962
Opened 14 years ago
Closed 14 years ago
Drop the check for updates menuitem
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 5.0b1
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
7.67 KB,
patch
|
protz
:
review+
|
Details | Diff | Splinter Review |
With bug 650231, we have put the check for updates functionality into the About window. We therefore no longer need that functionality in the Help menu (or application menu on Mac).
We can just remove the appropriate items. I'm taking Blake's bug 650231 comment 37 as implicit ui-review+.
It has one string removal, so I'd like to get it in today if possible, before we string freeze.
Attachment #531276 -
Flags: review?(jonathan.protzenko)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 531276 [details] [diff] [review]
The fix
Review of attachment 531276 [details] [diff] [review]:
-----------------------------------------------------------------
Given that the only ifdefs in utilityOverlay.js were for MOZ_UPDATER, having it non-processed now seems fine. It looks like you haven't forgotten to remove anything, so r+ :-).
Attachment #531276 -
Flags: review?(jonathan.protzenko) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
You need to log in
before you can comment on or make changes to this bug.
Description
•