656002 - about:newtab shows "Reload Tab" enabled in the tab right click menu

Status: RESOLVED WONTFIX

(Firefox :: Menus, defect)

Description

[alex_mayorga]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:6.0a1) Gecko/20110509 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Windows NT 6.0; rv:6.0a1) Gecko/20110509 Firefox/6.0a1

Given their static nature about:home and about:blank shouldn't be "re-loadable".

Reproducible: Always

Steps to Reproduce:
1. Open a new window that loads about:home or about:blank
2. Right click on the about:home or about:blank tab
3.

Actual Results:  
about:home and about:blank show "Reload Tab" in the tab right click menu

Expected Results:  
about:home and about:blank don't show "Reload Tab" in the tab right click menu

Maybe slightly related to bug 594050

Comment 1

[eyal gruss]

for consistency, it should be disabled, not hidden.

Comment 2

[Thomas Ahlblom]

Reproduced.
Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110514 Firefox/6.0a1

Comment 3

[Bill Gianopoulos [:WG9s]]

1.  The about:home page is NOT static.  If you reload it, the "snippet" will change.

2.  The reload context menu choice is disabled for me for the about:blank page with current trunk nightly builds.

Comment 4

[Bill Gianopoulos [:WG9s]]

 (In reply to comment #3)
> 2.  The reload context menu choice is disabled for me for the about:blank
> page with current trunk nightly builds.

OIC.  Although the context menu on the content area correctly disables the "Reload" choice in the context menu, the "Reload Tab" choice in the context menu on the tab itself is not disabled.  I guess I should have more closely read the steps to reproduce.

Comment 5

[Felix Fung (:felix)]

Attachment: Reload Option Doesn't Make Sense for "about:blank" Tabs

Summary of Changes
- When context menu is loaded, check the uri for that tab to see if it's blank.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 563670 [details] [diff] [review]
Reload Option Doesn't Make Sense for "about:blank" Tabs

>+    let tabUri = gBrowser.getBrowserForTab(this.contextTab).currentURI.spec;
>+    document.getElementById("context_reloadTab").disabled =
>+      tabUri == "" || tabUri == "about:blank";

use isTabEmpty

Comment 7

[Felix Fung (:felix)]

isTabEmpty isn't exactly right. isTabEmpty wants that there's no history as well as being about:blank. In our case, we don't really care about having a history.

Comment 8

[Felix Fung (:felix)]

Attachment: Reload Option Doesn't Make Sense for "about:blank" Tabs

Additional Changes:
- isTabEmpty equivalent renamed to isTabEmptyNew
- isTabEmpty doesn't require empty history to be considered empty

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 584246 [details] [diff] [review]
Reload Option Doesn't Make Sense for "about:blank" Tabs

This is obsolete now that about:newtab has landed.

I don't think this bug is worth spending time on at all...

Comment 10

[:Gavin Sharp [email: [e-mail]]]

I agree

Comment 11

[alex_mayorga]

The issue described on comment 0 still exist, jut now in about:newtab

Comment 12

[Dão Gottwald [:dao]]

(In reply to alex_mayorga from comment #11)
> The issue described on comment 0 still exist, jut now in about:newtab

WONTFIX doesn't mean what's been described doesn't exist, it means that we don't want to invest in fixing it.