Closed Bug 656018 Opened 14 years ago Closed 12 years ago

new Bookmark Name Field is blank when dragging the Site Icon to the Bookmarks Sidebar Icon

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: sarah.robinson, Unassigned)

References

(
URL
)

Details

(Keywords: regression)

User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110510 Firefox/6.0a1 Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110510 Firefox/6.0a1 When creating a new bookmark by dragging the site's icon (either from the url bar or the tab) to the bookmarks icon, the "Name" field is left blank on the New Bookmark pop-up (the old style New Bookmark pop-up window, not the one that comes up when clicking the star icon). It had previously been filled in with the page title in older versions. Reproducible: Always Steps to Reproduce: 1. Drag a site icon to the bookmarks icon. 2. Drop it. 3. New Bookmark window should pop up with blank name field. Actual Results: The Name field is left blank. Expected Results: The Name field should contain the page title.
Can you reproduce in safe mode (http://support.mozilla.com/kb/Safe+Mode)? Which "bookmarks icon" do you mean?
(In reply to comment #1) > Can you reproduce in safe mode (http://support.mozilla.com/kb/Safe+Mode)? > Which "bookmarks icon" do you mean? The bookmarks icon that has a book with a star on it. It brings up the searchable Bookmarks list when you click it. The one you can add to a toolbar via preferences. I can reproduce it in safe mode IF I add the bookmarks icon back to the toolbar first.
(In reply to comment #2) > I can reproduce it in safe mode IF I add the bookmarks icon back to the > toolbar first. Could I get the steps to reproduce in safe mode then, please. You drag from the locationbar favicon to the toolbar (does it have a title then?) then you drag from the toolbar to the button? do you release on the button or on the menu opened by the button?
(In reply to comment #3) > (In reply to comment #2) > > I can reproduce it in safe mode IF I add the bookmarks icon back to the > > toolbar first. > > Could I get the steps to reproduce in safe mode then, please. You drag from > the locationbar favicon to the toolbar (does it have a title then?) then you > drag from the toolbar to the button? do you release on the button or on the > menu opened by the button? Safemode steps: 1. Right-click on the toolbar, click customize (I said "preferences" earlier but I meant customize, sorry). 2. Locate the bookmarks icon and drag&drop it to the toolbar. Close the customize window. 3. Then drag the icon on the left side of the url on top of the added bookmarks icon and drop it. That's the icon, not the bookmarks list or the menu, neither of those need to be open for this to work.
Ah, customize breaks a bunch of stuff, as seen in bug 575896, so this could be an effect of that.
ehr, I actually wanted to link bug 625778.
Ermm, I can repro against Trunk, but that mentioned Icon is the Bookmark Sidebar Icon. Shouldn't that be considered as a invalid Drag/Drop Target for Favicon-Dropping/One-Click-Bookmarking anyways?
Version: unspecified → Trunk
(In reply to comment #7) > Ermm, I can repro against Trunk, but that mentioned Icon is the Bookmark > Sidebar Icon. Shouldn't that be considered as a invalid Drag/Drop Target for > Favicon-Dropping/One-Click-Bookmarking anyways? Ah, no, that icons has a special handling to allow bookmarking by dropping on it, and looks like it broke. I was able to reproduce this way.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Ok, there are two Regression Windows: Last good nightly: 2010-04-18 First bad nightly: 2010-04-19 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c15e44e90870&tochange=85c3175de68f => Expected Behavior changes to "Drop Target not allowed" Icon. Last good nightly: 2010-04-19 First bad nightly: 2010-04-20 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=85c3175de68f&tochange=5f229488969c => "Drop Target not allowed" Icon changes to current Behavior. Maybe caused by some of Neil's Checkins to Drag/Drop Code in both Ranges?
Keywords: regression
Summary: New Bookmark Name field is blank when dragging the site icon to the bookmarks icon → new Bookmark Name Field is blank when dragging the Site Icon to the Bookmarks Sidebar Icon
the handling code is here http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3082 It uses the new methods introduced by Neil in the above changesets, looks like name is empty. Maybe it should just pass name.value to the showMinimalAddBookmarkUI method (if so there is a similar bug in DownloadsButtonDNDObserver). Otherwise should check what's in the datatransfer and why before there was a title.
Whiteboard: [good first bug]
Hi, i am new here and i would like to work on this bug. However, i can not reproduce it on my x64 machine (on both Windows 7 and Linux 12.04). Could anyone assist me with this ? Thanks a lot!
mak, I can't reproduce this. I think it probably the underlying ui and code has changed so much in the last couple of years that it probably shouldn't be marked as a good first bug. It possibly isn't a bug at all anymore. What do you think?
Flags: needinfo?(mak77)
I cannot reproduce anymore as well, it's very likely it got fixed when refactoring the bookmarks dialogs code... Thanks.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(mak77)
Resolution: --- → WORKSFORME
Whiteboard: [good first bug]
Firefox 33 beta and above are currently bookmarking without initially showing the bookmark name in the dialog box when creating the bookmark; the dialog box displays "empty". Although, immediately after bookmarking the bookmark does show its unedited bookmark name. Is this a new feature of Firefox 33 and above or is it a bug? Seems like a bug to me though if it is a new feature it is something to get used to.
I resolved this in my PC with resetting Firefox 33 Beta in Trouble-Shooting and Help. So this is not a Firefox Code bug. Please disregard comment #14 as a bug issue report.
sounds like a problem with an add-on, indeed.
You need to log in before you can comment on or make changes to this bug.