Update Scratchpad menu access key to S

VERIFIED FIXED in Firefox 6

Status

defect
VERIFIED FIXED
8 years ago
11 months ago

People

(Reporter: rcampbell, Assigned: rcampbell)

Tracking

unspecified
Firefox 6

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

8 years ago
Was supposed to get this before landing bug 653221 but missed it. We should move the access key to 'S' for en-US in the Web Developer menu.
Assignee

Comment 1

8 years ago
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #531333 - Flags: review?
Since this has landed on mozilla-central now, I think you need to change the entity name as well so localizers know that it has changed.
Assignee

Comment 3

8 years ago
augh, imo.
Comment on attachment 531333 [details] [diff] [review]
[checked-in] change scratchpad accesskey to 's'

r=me on landing this without a key change, as this is the same context.

Post in .l10n for those using en-US accesskeys is good enough.
Attachment #531333 - Flags: review+
Assignee

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Assignee

Comment 5

8 years ago
Comment on attachment 531333 [details] [diff] [review]
[checked-in] change scratchpad accesskey to 's'

http://hg.mozilla.org/mozilla-central/rev/a99f84efbb20
Attachment #531333 - Attachment description: change scratchpad accesskey to 's' → [checked-in] change scratchpad accesskey to 's'
's' is already the accesskey for "Save page as...". Is that one changing? Is there a qualifier (shift?) that I'm not seeing in this patch?
Assignee

Comment 7

8 years ago
accesskey is just to "access" the feature when navigating the menus with keyboard. accelerator/commandkey for the Scratchpad is F4. Doesn't conflict with Save As.
Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110511 Firefox/6.0a1

Verified on Linux and Windows, 's' key brings up the Scratchpad when navigating through the menu. Even if the platform for this issue is set to Mac OS X, the same behaviour is not encountered on Mac. Should this apply for Mac also?
Assignee

Comment 9

8 years ago
Simona, my mistake. I filed on a Mac and those fields were pre-populated for me.

Accesskey behavior's a little funny on the Mac and not really consistent with Windows and Linux.

Thanks for verifying this!
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Assignee

Updated

8 years ago
Attachment #531333 - Flags: review?

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.