Closed
Bug 656021
Opened 14 years ago
Closed 14 years ago
Update Scratchpad menu access key to S
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 6
People
(Reporter: rcampbell, Assigned: rcampbell)
Details
Attachments
(1 file)
1.11 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
Was supposed to get this before landing bug 653221 but missed it. We should move the access key to 'S' for en-US in the Web Developer menu.
Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Since this has landed on mozilla-central now, I think you need to change the entity name as well so localizers know that it has changed.
Assignee | ||
Comment 3•14 years ago
|
||
augh, imo.
Comment 4•14 years ago
|
||
Comment on attachment 531333 [details] [diff] [review] [checked-in] change scratchpad accesskey to 's' r=me on landing this without a key change, as this is the same context. Post in .l10n for those using en-US accesskeys is good enough.
Attachment #531333 -
Flags: review+
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Assignee | ||
Comment 5•14 years ago
|
||
Comment on attachment 531333 [details] [diff] [review] [checked-in] change scratchpad accesskey to 's' http://hg.mozilla.org/mozilla-central/rev/a99f84efbb20
Attachment #531333 -
Attachment description: change scratchpad accesskey to 's' → [checked-in] change scratchpad accesskey to 's'
Comment 6•14 years ago
|
||
's' is already the accesskey for "Save page as...". Is that one changing? Is there a qualifier (shift?) that I'm not seeing in this patch?
Assignee | ||
Comment 7•14 years ago
|
||
accesskey is just to "access" the feature when navigating the menus with keyboard. accelerator/commandkey for the Scratchpad is F4. Doesn't conflict with Save As.
Comment 8•14 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110511 Firefox/6.0a1 Verified on Linux and Windows, 's' key brings up the Scratchpad when navigating through the menu. Even if the platform for this issue is set to Mac OS X, the same behaviour is not encountered on Mac. Should this apply for Mac also?
Assignee | ||
Comment 9•14 years ago
|
||
Simona, my mistake. I filed on a Mac and those fields were pre-populated for me. Accesskey behavior's a little funny on the Mac and not really consistent with Windows and Linux. Thanks for verifying this!
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Updated•13 years ago
|
Attachment #531333 -
Flags: review?
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•