656087 - Windows jumplists don't work with different app-name

Status: RESOLVED WORKSFORME

(Firefox :: Shell Integration, defect)

Description

[Mark Straver]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

When a different app-name for firefox is used (e.g. a rebranded browser), the windows jumplist functionality ceases to work.

The error console will occasionally display the following error:
Error: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIJumpListShortcut.app]
Source file: resource://gre/modules/WindowsJumpLists.jsm
Line: 453

The error is easy to reproduce by simply renaming firefox.exe to something else. It will immediately lead to broken jumplists.


Reproducible: Always

Steps to Reproduce:
1. Install a rebranded firefox browser OR rename firefox.exe to something else
2. Try to use jumplist funtionality


Actual Results:  
Errors in the error console and no jumplist functionality

Expected Results:  
Working jumplists regardless of app-name.

A few lines above the line indicated in the error is a hard-coded string "firefox.exe" -- this would be the culprit. It probably needs to be parameterized in the build process to fill it with the correct app-name at build time.

Comment 1

[AndreiD[QA]]

I could reproduce the issue on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0a1) Gecko/20110622 Firefox/7.0a1

>The error console will occasionally display the following error

Are there specific websites that generate this error? I got the error after logging into my Yahoo e-mail account, for example.

Comment 2

[Mark Straver]

(In reply to comment #1)
> Are there specific websites that generate this error? I got the error after
> logging into my Yahoo e-mail account, for example.

It's seems a little erratic when this shows up. I'm not sure what triggers it, but it did point me in the right direction re: cause.

I can confirm that putting the exact app .exe name in the place of "firefox.exe" fixes the bug, and I've happily been using jumplists since then.

Comment 3

[AndreiD[QA]]

Reproducible also on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0a1) Gecko/20110626 Firefox/7.0a1

Setting this as NEW.

Comment 4

[Don Kleppinger]

Bug 942938 is related

Comment 5

[Mike Kaply [:mkaply]]

This shouldn't be done at build time. It should be queried from the command line parameters (the first parameter is the EXE).

Comment 6

[Andrei Purice]

Hey Mark,
Can you still reproduce this or should we close it?
I tried on the latest versions of Firefox and it works for me.

Comment 7

[Mark Straver]

Looks like this was fixed in bug 789469 -- you can close this

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.