656426 - [traceback] KeyError: '' @ /files/compare/115275...69883/#top

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.allizom.org/en-US/firefox/files/compare/115275...69883/#top

traceback details:

File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/files/decorators.py", line 53, in wrapper
   return func(request, DiffHelper(one, two), *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/files/views.py", line 102, in files_compare
   files = diff.get_files()

 File "/data/amo_python/www/preview/zamboni/apps/amo/utils.py", line 445, in wrapper
   data = func(*args, **kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/files/helpers.py", line 248, in get_files
   file_one_files[key]['diff'] = True

KeyError: ''

Comment 1

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/637f7d7e7ef154cb40766ffdbfc638f08a2cadfc