656488 - Command-H to hide app doesn't work when in Panorama

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Erik Rose [:erik][:erikrose]]

When in Panorama mode, hitting command-H doesn't hide Aurora. The application menu blinks, but nothing else happens. Selecting Hide Aurora with the mouse does work.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v2

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 535264 [details] [diff] [review]
v2

Review of attachment 535264 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 535264 [details] [diff] [review]
v2

Review of attachment 535264 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabview/ui.js
@@ +1034,5 @@
>        function processBrowserKeys(evt) {
> +        // let any keys with alt to pass through
> +        if (evt.altKey)
> +          return;
> +

With this, do we still need the special treatment for hideThisAppCmdMac?

Comment 5

[Raymond Lee [:raymondlee]]

(In reply to comment #4)
> Comment on attachment 535264 [details] [diff] [review] [review]
> v2
> 
> Review of attachment 535264 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/tabview/ui.js
> @@ +1034,5 @@
> >        function processBrowserKeys(evt) {
> > +        // let any keys with alt to pass through
> > +        if (evt.altKey)
> > +          return;
> > +
> 
> With this, do we still need the special treatment for hideThisAppCmdMac?

yes, we do.  hideThisAppCmdMac => cmd/ctrl + H.  We don't need special treatment for hideOtherAppsCmdMac => cmd/ctrl + alt + H

Comment 6

[Raymond Lee [:raymondlee]]

Comment on attachment 535264 [details] [diff] [review]
v2

Passed Try
http://tbpl.mozilla.org/?tree=Try&rev=fd16aca86305

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 9

[Raymond Lee [:raymondlee]]

Attachment: v2.1

Updated it to work with the latest trunk.  Trivial patch.

Comment 10

[Ian Gilman [:iangilman]]

Comment on attachment 537067 [details] [diff] [review]
v2.1

Review of attachment 537067 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good

Comment 11

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/d77e733fc507

Comment 13

[George Carstoiu]

Verified on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110609 Firefox/7.0a1.

Pressing Command + H while in Panorama hides Firefox - problem no longer exists. Setting status to VERIFIED FIXED.