The default bug view has changed. See this FAQ.

Command-H to hide app doesn't work when in Panorama

VERIFIED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
P2
normal
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: erik, Assigned: raymondlee)

Tracking

Trunk
Firefox 7
x86
Mac OS X
Dependency tree / graph

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

6 years ago
When in Panorama mode, hitting command-H doesn't hide Aurora. The application menu blinks, but nothing else happens. Selecting Hide Aurora with the mouse does work.
Blocks: 653099
Depends on: 621795
(Assignee)

Comment 1

6 years ago
Created attachment 534995 [details] [diff] [review]
v1
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #534995 - Flags: feedback?(tim.taubert)
(Assignee)

Comment 2

6 years ago
Created attachment 535264 [details] [diff] [review]
v2
Attachment #534995 - Attachment is obsolete: true
Attachment #534995 - Flags: feedback?(tim.taubert)
Attachment #535264 - Flags: feedback?(tim.taubert)
Comment on attachment 535264 [details] [diff] [review]
v2

Review of attachment 535264 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #535264 - Flags: feedback?(tim.taubert) → feedback+
(Assignee)

Updated

6 years ago
Attachment #535264 - Flags: review?(ian)
Comment on attachment 535264 [details] [diff] [review]
v2

Review of attachment 535264 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabview/ui.js
@@ +1034,5 @@
>        function processBrowserKeys(evt) {
> +        // let any keys with alt to pass through
> +        if (evt.altKey)
> +          return;
> +

With this, do we still need the special treatment for hideThisAppCmdMac?
(Assignee)

Comment 5

6 years ago
(In reply to comment #4)
> Comment on attachment 535264 [details] [diff] [review] [review]
> v2
> 
> Review of attachment 535264 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/tabview/ui.js
> @@ +1034,5 @@
> >        function processBrowserKeys(evt) {
> > +        // let any keys with alt to pass through
> > +        if (evt.altKey)
> > +          return;
> > +
> 
> With this, do we still need the special treatment for hideThisAppCmdMac?

yes, we do.  hideThisAppCmdMac => cmd/ctrl + H.  We don't need special treatment for hideOtherAppsCmdMac => cmd/ctrl + alt + H
(Assignee)

Comment 6

6 years ago
Comment on attachment 535264 [details] [diff] [review]
v2

Passed Try
http://tbpl.mozilla.org/?tree=Try&rev=fd16aca86305
bugspam
No longer blocks: 653099
bugspam
Blocks: 660175
(Assignee)

Comment 9

6 years ago
Created attachment 537067 [details] [diff] [review]
v2.1

Updated it to work with the latest trunk.  Trivial patch.
Attachment #535264 - Attachment is obsolete: true
Attachment #535264 - Flags: review?(ian)
Attachment #537067 - Flags: review?(ian)
Comment on attachment 537067 [details] [diff] [review]
v2.1

Review of attachment 537067 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good
Attachment #537067 - Flags: review?(ian) → review+
(Assignee)

Comment 11

6 years ago
Created attachment 537165 [details] [diff] [review]
Patch for checkin
Attachment #537067 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/d77e733fc507
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 5 → Firefox 7

Comment 13

6 years ago
Verified on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110609 Firefox/7.0a1.

Pressing Command + H while in Panorama hides Firefox - problem no longer exists. Setting status to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.