65661 - XPCOM plugin instances not destroyed

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Nicholas Hart]

It seems that when I embed multiple XPCOM plugins on a page and close NS6, ONE 
of the plugins has its SetWindow(NULL), Stop() and Destroy() functions called, 
however, the other one has none of these functions called.  Then the process 
dies.

This causes intermittent crashes in our plugin.  We need to receive proper 
notification of the plugin destruction in order to clean up properly.

The NS4.x API was very good about making sure that NPP_Destroy was called.  It 
would be nice if NS6 called Stop() and Destroy() reliably as well.

Comment 1

[shrirang khanzode]

status :new

Comment 2

[Peter Lubczynski]

Could this be causing the Assertion that the Service Manager is help past 
shutdown?

Comment 3

[Peter Lubczynski]

Can someone attach a testcase?

Comment 4

[karnaze (gone)]

Moving to m0.9.1.

Comment 5

[av (gone)]

I have a patch for bug 74485 waiting for a superreview. It could really fix this 
one as I quite profoundly revised the shutdown procedures in 
nsPluginHostImpl.cpp

Comment 6

[av (gone)]

Nicholas, could you please try the latest build? Also, do you have nsIPlugin 
implemented in your plugin?

Stealing from Peter.

Comment 7

[av (gone)]

I tried it with three instances of the Simple plugin and hit break points 
reliably on both SetWindow and Destroy three times each. Marking fixed.

Comment 8

[shrirang khanzode]

spam : verif/fixed (rubberstamp)