656954 - Add defaultPrevented to nsIDOMEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

We have non-standard getPreventDefault() in nsIDOMNSEvent, but we should
deprecate that at some point and start using defaultPrevented.
But first, implement defaultPrevented.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/932a10564fbc

Comment 3

[Frank Yan (:fryn)]

Comment on attachment 532339 [details] [diff] [review]
patch

(just took a look at the changeset on m-c out of curiosity)

> +is(e.defaultPrevented, false,
> +   "After creating event defaultPrevented should be true");

Was the second line supposed to be "After creating event defaultPrevented should be _false_" ? ;)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

yes!
I'll fix that.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/5a47fba510f3

Comment 6

[Eric Shepherd [:sheppy]]

Documentation added:
https://developer.mozilla.org/en/DOM/event.defaultPrevented

Updated:

https://developer.mozilla.org/en/DOM/event.preventDefault
https://developer.mozilla.org/en/DOM/event

Mentioned on Firefox 6 for developers.