714601 - Use defaultPrevented instead of the deprecated getPreventDefault() in xul/content/static.js

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #707677 +++

event.getPreventDefault is deprecated, we should use event.defaultPrevented instead.

Comment 1

[Donald Sarratt]

Attachment: Replaces deprecated method

As far as I can tell this is all that needs to be done.

Comment 2

[:Cykesiopka]

Comment on attachment 659520 [details] [diff] [review]
Replaces deprecated method

It looks like Donald's patch still applies.

Comment 3

[Glen Mailer]

In general ChatZilla tries to maintain backwards compatibility, how deprecated is the method - and how far back does support for the property go?

Comment 4

[:Gijs (out for now; he/him)]

Comment on attachment 659520 [details] [diff] [review]
Replaces deprecated method

(In reply to Glen Mailer from comment #3)
> In general ChatZilla tries to maintain backwards compatibility, how
> deprecated is the method - and how far back does support for the property go?

Gecko 6.0 according to https://developer.mozilla.org/en-US/docs/DOM/event.defaultPrevented . So this patch won't be good enough, sadly. :-(

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Replaces deprecated method, v2

Patch with polyfill

Comment 6

[:Gijs (out for now; he/him)]

Attachment: Patch with utility function

Personally, I'm not a fan of prototype messing-abouts, and would prefer something like this. I'll leave it to James to decide.

Comment 7

[James Ross]

Comment on attachment 751684 [details] [diff] [review]
Replaces deprecated method, v2

Even AMO's unreliable checks will probably cry over this method too.

Comment 8

[:Gijs (out for now; he/him)]

Pushed, http://hg.mozilla.org/chatzilla/rev/7076cb689fb4