Last Comment Bug 656996 - Remove NS_NewHTMLCSSUtils
: Remove NS_NewHTMLCSSUtils
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
-- minor (vote)
: mozilla6
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Makoto Kato [:m_kato]
Depends on:
Blocks: deCOM
  Show dependency treegraph
Reported: 2011-05-13 12:59 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-07-27 04:08 PDT (History)
3 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (8.62 KB, patch)
2011-05-13 12:59 PDT, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2011-05-13 12:59:18 PDT
Created attachment 532320 [details] [diff] [review]
Patch v1
Comment 1 User image :Ehsan Akhgari 2011-05-14 09:04:06 PDT
Comment on attachment 532320 [details] [diff] [review]
Patch v1

> class nsHTMLCSSUtils
> {
> public:
>-  nsHTMLCSSUtils();
>+  nsHTMLCSSUtils(nsHTMLEditor* aEditor);

Mark the ctor as explicit, please?

r=me with that.  Oh, and keep these patches coming!  The editor needs these types of cleanups badly.
Comment 2 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-05-15 06:48:14 PDT
Why is this a heap allocated class at all?  It only has two member variables; it looks like with a bit of API refactoring this could be a namespace class.
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2011-05-15 07:47:20 PDT
Feel free to file a followup.
Comment 4 User image Vlad [QA] 2011-07-27 04:08:51 PDT
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0b3

Note You need to log in before you can comment on or make changes to this bug.