Closed
Bug 656996
Opened 15 years ago
Closed 15 years ago
Remove NS_NewHTMLCSSUtils
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla6
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
8.62 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #532320 -
Flags: review?(ehsan)
Flags: in-testsuite-
|
||
Comment 1•15 years ago
|
||
Comment on attachment 532320 [details] [diff] [review]
Patch v1
> class nsHTMLCSSUtils
> {
> public:
>- nsHTMLCSSUtils();
>+ nsHTMLCSSUtils(nsHTMLEditor* aEditor);
Mark the ctor as explicit, please?
r=me with that. Oh, and keep these patches coming! The editor needs these types of cleanups badly.
Attachment #532320 -
Flags: review?(ehsan) → review+
Why is this a heap allocated class at all? It only has two member variables; it looks like with a bit of API refactoring this could be a namespace class.
|
Assignee | |
Comment 3•15 years ago
|
||
Feel free to file a followup.
http://hg.mozilla.org/mozilla-central/rev/4077327becc2
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla6
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0b3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•