Last Comment Bug 657160 - Remove NS_NewHTMLEditRules, NS_NewTextEditRules and NS_NewCare
: Remove NS_NewHTMLEditRules, NS_NewTextEditRules and NS_NewCare
Status: VERIFIED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks: deCOM
  Show dependency treegraph
 
Reported: 2011-05-14 12:30 PDT by :Ms2ger
Modified: 2011-07-27 04:29 PDT (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
NS_NewHTMLEditRules (3.18 KB, patch)
2011-05-14 12:30 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review
NS_NewTextEditRules (3.52 KB, patch)
2011-05-14 12:31 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review
NS_NewCare (3.99 KB, patch)
2011-05-14 12:31 PDT, :Ms2ger
ehsan: review+
roc: review+
Details | Diff | Review

Description :Ms2ger 2011-05-14 12:30:32 PDT
Created attachment 532461 [details] [diff] [review]
NS_NewHTMLEditRules
Comment 1 :Ms2ger 2011-05-14 12:31:17 PDT
Created attachment 532462 [details] [diff] [review]
NS_NewTextEditRules
Comment 2 :Ms2ger 2011-05-14 12:31:46 PDT
Created attachment 532463 [details] [diff] [review]
NS_NewCare
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2011-05-14 13:25:43 PDT
Comment on attachment 532462 [details] [diff] [review]
NS_NewTextEditRules

r=me, assuming that you'll make the code compile, and test it before landing.  ;-)
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2011-05-14 13:27:08 PDT
Comment on attachment 532463 [details] [diff] [review]
NS_NewCare

This looks good to me, but can you please ask roc to take a look as well?
Comment 5 :Ms2ger 2011-05-14 14:11:43 PDT
Comment on attachment 532463 [details] [diff] [review]
NS_NewCare

You mean your compiler doesn't do automatic semicolon insertion? :)
Comment 6 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-05-14 19:37:21 PDT
Comment on attachment 532463 [details] [diff] [review]
NS_NewCare

Review of attachment 532463 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 8 Vlad [QA] 2011-07-27 04:29:53 PDT
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0b3

Note You need to log in before you can comment on or make changes to this bug.