657218 - UI for new archive granularity uses false accesskey entity for keepArchives

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

The following XUL code uses a false accesskey entity in comm-trunk and comm-miramar 2011-05-15 builds:

<checkbox wsm_persist="true" id="identity.archiveEnabled"
          label="&keepArchives.label;"
          accesskey="&fccMailFolder.accesskey;"
          prefattribute="value"
          prefstring="mail.identity.%identitykey%.archive_enabled"
          oncommand="setupArchiveItems();"/>

&fccMailFolder.accesskey; has to be replaced by &keepArchives.accesskey;

Comment 1

[rsx11m]

This should block 3.3 as it affects localizers.

Comment 2

[rsx11m]

Attachment: Easy fix

Patch based on Alex's observation. I've double-checked all access keys in both am-copiesOverlay.xul and am-archiveoptions.xul for any other wrong definitions, but that appears to be the only one. As a drive-by fix, I've adjusted some code formatting in archiveGranularity to make it consistent (white spaces only).

Comment 3

[Mark Banner (:standard8)]

Thankfully, keepArchives.accesskey is already defined and we don't have to worry about the string freeze.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 532519 [details] [diff] [review]
Easy fix

>-      <radio label="&archiveFlat.label;" accesskey="&archiveFlat.accesskey;"
>-             class="indent"/>
>+      <radio label="&archiveFlat.label;"
>+             accesskey="&archiveFlat.accesskey;" class="indent"/>

I don't think we need this change. The existing version isn't messy, and it hasn't got anything to do with this bug.

r=Standard8 with that removed from the patch.

Comment 5

[Mark Banner (:standard8)]

I checked this in without the extra change ready for today's nightly:

http://hg.mozilla.org/comm-central/rev/166b7163d9aa

Comment 6

[rsx11m]

(In reply to comment #4)
> I don't think we need this change. The existing version isn't messy, and it
> hasn't got anything to do with this bug.

Thanks Mark. I've seen this while scanning through the code and adjusted the white spaces on the fly, certainly no problem to leave it as is.

Comment 7

[rsx11m]

Attachment: Final patch

I don't know if you wanted me to provide an updated patch for easier check-in on the Miramar branch, but here it is.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 532645 [details] [diff] [review]
Final patch

Thanks for the extra patch. Checked in:

http://hg.mozilla.org/releases/comm-miramar/rev/f82235c21b19