Intermittent timeout in browser/base/content/test/tabview/browser_tabview_undo_group.js

VERIFIED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: raymondlee)

Tracking

({intermittent-failure})

Trunk
Firefox 7
x86
Windows XP
intermittent-failure
Dependency tree / graph

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1305268695.1305270014.3550.gz&fulltext=1
(Reporter)

Updated

6 years ago
Assignee: nobody → tim.taubert
Blocks: 653099, 438871
Status: NEW → ASSIGNED
Whiteboard: [orange]
(Reporter)

Updated

6 years ago
Assignee: tim.taubert → nobody
Status: ASSIGNED → NEW
(Reporter)

Comment 1

6 years ago
bugspam
No longer blocks: 653099
(Reporter)

Comment 2

6 years ago
bugspam
Blocks: 660175
(Assignee)

Comment 3

6 years ago
Created attachment 536231 [details] [diff] [review]
v1

Based on the link in comment 0, the previous test is still running after finish() is called which might be the cause of the problem.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #536231 - Flags: feedback?(tim.taubert)
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> Created attachment 536231 [details] [diff] [review] [review]
> v1
> 
> Based on the link in comment 0, the previous test is still running after
> finish() is called which might be the cause of the problem.

Passed Try:
http://tbpl.mozilla.org/?tree=Try&rev=7febbe87498d
(Reporter)

Comment 5

6 years ago
Comment on attachment 536231 [details] [diff] [review]
v1

Review of attachment 536231 [details] [diff] [review]:
-----------------------------------------------------------------

For some reason Utils.log() is used instead of SimpleTest.info() and the first seems to have buffering enabled so that the console message output is slightly delayed. If you exchange that with info() it's perfectly in line.

The test is actually failing here:

>  let closeButton = groupItem.container.getElementsByClassName("close");
>  ok(closeButton, "Group item close button exists");
>  EventUtils.sendMouseEvent({ type: "click" }, closeButton[0], contentWindow);

So maybe we should add a waitForFocus() call for the contentWindow here after the tabview is shown. Alas, I can't see anything obviously intermittent...
Attachment #536231 - Flags: feedback?(tim.taubert) → feedback-
(Assignee)

Comment 6

6 years ago
Created attachment 536282 [details] [diff] [review]
v2
Attachment #536231 - Attachment is obsolete: true
Attachment #536282 - Flags: feedback?(tim.taubert)
(Reporter)

Comment 7

6 years ago
Comment on attachment 536282 [details] [diff] [review]
v2

Review of attachment 536282 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/tabview/browser_tabview_startup_transitions.js
@@ +42,5 @@
> +
> +        tabViewWindow.document.removeEventListener(
> +          "transitionend", onTransitionEnd, false);
> +
> +        win.close();

Nit: Please add "registerCleanupFunction(function () win.close())" instead of this line to ensure the window gets closed when timing out.
Attachment #536282 - Flags: feedback?(tim.taubert) → feedback+
(Assignee)

Comment 8

6 years ago
Created attachment 536318 [details] [diff] [review]
v3
Attachment #536282 - Attachment is obsolete: true
Attachment #536318 - Flags: review?(ian)
Comment on attachment 536318 [details] [diff] [review]
v3

Review of attachment 536318 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me
Attachment #536318 - Flags: review?(ian) → review+
(Assignee)

Comment 10

6 years ago
Created attachment 536503 [details] [diff] [review]
Patch for checkin
Attachment #536318 - Attachment is obsolete: true
(Reporter)

Comment 11

6 years ago
http://hg.mozilla.org/mozilla-central/rev/316299946b8f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
(Reporter)

Comment 12

6 years ago
Adding intermittent test failures to new meta bug.

(bugspam)
Blocks: 665844
Setting status to verified fixed based on the results in: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1314769105.1314770462.11076.gz.
Status: RESOLVED → VERIFIED
Keywords: intermittent-failure
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.