Closed Bug 657219 Opened 13 years ago Closed 13 years ago

Intermittent timeout in browser/base/content/test/tabview/browser_tabview_undo_group.js

Categories

(Firefox Graveyard :: Panorama, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 7

People

(Reporter: ttaubert, Assigned: raymondlee)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 3 obsolete files)

Assignee: nobody → tim.taubert
Blocks: 653099, 438871
Status: NEW → ASSIGNED
Whiteboard: [orange]
Assignee: tim.taubert → nobody
Status: ASSIGNED → NEW
bugspam
No longer blocks: 653099
bugspam
Blocks: 660175
Attached patch v1 (obsolete) — Splinter Review
Based on the link in comment 0, the previous test is still running after finish() is called which might be the cause of the problem.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #536231 - Flags: feedback?(tim.taubert)
(In reply to comment #3)
> Created attachment 536231 [details] [diff] [review] [review]
> v1
> 
> Based on the link in comment 0, the previous test is still running after
> finish() is called which might be the cause of the problem.

Passed Try:
http://tbpl.mozilla.org/?tree=Try&rev=7febbe87498d
Comment on attachment 536231 [details] [diff] [review]
v1

Review of attachment 536231 [details] [diff] [review]:
-----------------------------------------------------------------

For some reason Utils.log() is used instead of SimpleTest.info() and the first seems to have buffering enabled so that the console message output is slightly delayed. If you exchange that with info() it's perfectly in line.

The test is actually failing here:

>  let closeButton = groupItem.container.getElementsByClassName("close");
>  ok(closeButton, "Group item close button exists");
>  EventUtils.sendMouseEvent({ type: "click" }, closeButton[0], contentWindow);

So maybe we should add a waitForFocus() call for the contentWindow here after the tabview is shown. Alas, I can't see anything obviously intermittent...
Attachment #536231 - Flags: feedback?(tim.taubert) → feedback-
Attached patch v2 (obsolete) — Splinter Review
Attachment #536231 - Attachment is obsolete: true
Attachment #536282 - Flags: feedback?(tim.taubert)
Comment on attachment 536282 [details] [diff] [review]
v2

Review of attachment 536282 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/tabview/browser_tabview_startup_transitions.js
@@ +42,5 @@
> +
> +        tabViewWindow.document.removeEventListener(
> +          "transitionend", onTransitionEnd, false);
> +
> +        win.close();

Nit: Please add "registerCleanupFunction(function () win.close())" instead of this line to ensure the window gets closed when timing out.
Attachment #536282 - Flags: feedback?(tim.taubert) → feedback+
Attached patch v3 (obsolete) — Splinter Review
Attachment #536282 - Attachment is obsolete: true
Attachment #536318 - Flags: review?(ian)
Comment on attachment 536318 [details] [diff] [review]
v3

Review of attachment 536318 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me
Attachment #536318 - Flags: review?(ian) → review+
Attachment #536318 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/316299946b8f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Adding intermittent test failures to new meta bug.

(bugspam)
Blocks: 665844
Setting status to verified fixed based on the results in: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1314769105.1314770462.11076.gz.
Status: RESOLVED → VERIFIED
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.