657268 - Shouldn't offer to save password if form submission is canceled

Status: RESOLVED DUPLICATE of bug 558178

(Toolkit :: Password Manager, defect, P3)

Description

[Leandro F]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

The popup message telling about possibility to save password posted in HTML FORM is always displayed incluing in moments when it should not be showed.

If my HTML form contains a onclick="return false" on input submit or a onsubmit="return false" on form tag. It correcly will block my FORM to POST data to the URL, but the popup always will be showed.
When the content is blocked to submit, that named "password doorhanger popup" always will be displayed, making ugly and inconvenient the apperance of websites.

Example:

	<form action="https://bugzilla.mozilla.org" method="post">
	     <input type="text" name="login" value="test" />
	     <input type="PASSWORD" name="password" value="test" />
	     <input type="submit" onclick="return false;" />
	</form>
	

Reproducible: Always

Steps to Reproduce:
1. Press submit button in a form than contains "return false"
2. 
3.

Actual Results:  
Popup about "Remember password" is displayed.

Expected Results:  
Do not show popup warning about possibility to save the login/password

Comment 1

[Justin Dolske [:Dolske]]

[I think there's already a bug on this.]

Ideally things could work this way, but sometimes sites process the login with an XMLHttpRequest, and cancel the actual form submission post. [Thus making the login process more responsive, because there's technically no new page load.] If the password manager didn't offer to save the password in that case, the user would be unable to save their password at all.

Comment 3

[Matthew N. [:MattN]]

We should double-check how other browsers handle this nowadays. I think others started copying us on this now.