657331 - Fix the registerCleanupFunction() in browser_tabview_bug625195.js

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Raymond Lee [:raymondlee]]

See bug 625195 comment 10.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 532613 [details] [diff] [review]
v1

Review of attachment 532613 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for doing this!

Comment 3

[Raymond Lee [:raymondlee]]

Comment on attachment 532613 [details] [diff] [review]
v1

Passed
http://tbpl.mozilla.org/?tree=Try&rev=926cf390c679

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Sorry, I'd like to give you r+ but I can't :)

Comment 6

[Raymond Lee [:raymondlee]]

(In reply to comment #5)
> Sorry, I'd like to give you r+ but I can't :)

I don't think we need r+ for fixing a test, right?

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #6)
> I don't think we need r+ for fixing a test, right?

We need r+ but not a+ for tests.

Comment 8

[Raymond Lee [:raymondlee]]

(In reply to comment #7)
> (In reply to comment #6)
> > I don't think we need r+ for fixing a test, right?
> 
> We need r+ but not a+ for tests.

Oh yes.

Comment 9

[Ian Gilman [:iangilman]]

Comment on attachment 532820 [details] [diff] [review]
Patch for checkin

Review of attachment 532820 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely :)

Comment 10

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Comment 11

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/c9413bd69b93