Last Comment Bug 657331 - Fix the registerCleanupFunction() in browser_tabview_bug625195.js
: Fix the registerCleanupFunction() in browser_tabview_bug625195.js
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
: -- normal
: Firefox 6
Assigned To: Raymond Lee [:raymondlee]
:
:
Mentors:
Depends on: 625195
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-16 05:31 PDT by Raymond Lee [:raymondlee]
Modified: 2016-04-12 14:00 PDT (History)
2 users (show)
mounir: in‑testsuite+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (1.32 KB, patch)
2011-05-16 05:43 PDT, Raymond Lee [:raymondlee]
ttaubert: feedback+
Details | Diff | Splinter Review
Patch for checkin (1.36 KB, patch)
2011-05-16 18:26 PDT, Raymond Lee [:raymondlee]
ian: review+
Details | Diff | Splinter Review
Patch for checkin (1.36 KB, patch)
2011-05-17 18:52 PDT, Raymond Lee [:raymondlee]
no flags Details | Diff | Splinter Review

Description Raymond Lee [:raymondlee] 2011-05-16 05:31:01 PDT
See bug 625195 comment 10.
Comment 1 Raymond Lee [:raymondlee] 2011-05-16 05:43:38 PDT
Created attachment 532613 [details] [diff] [review]
v1
Comment 2 Tim Taubert [:ttaubert] 2011-05-16 05:45:37 PDT
Comment on attachment 532613 [details] [diff] [review]
v1

Review of attachment 532613 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for doing this!
Comment 3 Raymond Lee [:raymondlee] 2011-05-16 18:24:06 PDT
Comment on attachment 532613 [details] [diff] [review]
v1

Passed
http://tbpl.mozilla.org/?tree=Try&rev=926cf390c679
Comment 4 Raymond Lee [:raymondlee] 2011-05-16 18:26:30 PDT
Created attachment 532820 [details] [diff] [review]
Patch for checkin
Comment 5 Tim Taubert [:ttaubert] 2011-05-17 01:59:55 PDT
Sorry, I'd like to give you r+ but I can't :)
Comment 6 Raymond Lee [:raymondlee] 2011-05-17 02:07:12 PDT
(In reply to comment #5)
> Sorry, I'd like to give you r+ but I can't :)

I don't think we need r+ for fixing a test, right?
Comment 7 Tim Taubert [:ttaubert] 2011-05-17 02:09:14 PDT
(In reply to comment #6)
> I don't think we need r+ for fixing a test, right?

We need r+ but not a+ for tests.
Comment 8 Raymond Lee [:raymondlee] 2011-05-17 02:09:51 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > I don't think we need r+ for fixing a test, right?
> 
> We need r+ but not a+ for tests.

Oh yes.
Comment 9 Ian Gilman [:iangilman] 2011-05-17 13:48:53 PDT
Comment on attachment 532820 [details] [diff] [review]
Patch for checkin

Review of attachment 532820 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely :)
Comment 10 Raymond Lee [:raymondlee] 2011-05-17 18:52:00 PDT
Created attachment 533144 [details] [diff] [review]
Patch for checkin
Comment 11 Mounir Lamouri (:mounir) 2011-05-19 06:12:38 PDT
http://hg.mozilla.org/mozilla-central/rev/c9413bd69b93

Note You need to log in before you can comment on or make changes to this bug.