The default bug view has changed. See this FAQ.

Fix the registerCleanupFunction() in browser_tabview_bug625195.js

RESOLVED FIXED in Firefox 6

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: raymondlee, Assigned: raymondlee)

Tracking

Trunk
Firefox 6
Bug Flags:
in-testsuite +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
See bug 625195 comment 10.
(Assignee)

Comment 1

6 years ago
Created attachment 532613 [details] [diff] [review]
v1
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #532613 - Flags: feedback?(tim.taubert)
Summary: Fix the registerCleanupFunction() in brobrowser_tabview_bug625195.js → Fix the registerCleanupFunction() in browser_tabview_bug625195.js
Comment on attachment 532613 [details] [diff] [review]
v1

Review of attachment 532613 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for doing this!
Attachment #532613 - Flags: feedback?(tim.taubert) → feedback+
(Assignee)

Updated

6 years ago
Depends on: 625195
(Assignee)

Comment 3

6 years ago
Comment on attachment 532613 [details] [diff] [review]
v1

Passed
http://tbpl.mozilla.org/?tree=Try&rev=926cf390c679
(Assignee)

Comment 4

6 years ago
Created attachment 532820 [details] [diff] [review]
Patch for checkin
Attachment #532613 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Sorry, I'd like to give you r+ but I can't :)
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
(In reply to comment #5)
> Sorry, I'd like to give you r+ but I can't :)

I don't think we need r+ for fixing a test, right?
(Assignee)

Updated

6 years ago
Attachment #532820 - Flags: review?(ian)
(In reply to comment #6)
> I don't think we need r+ for fixing a test, right?

We need r+ but not a+ for tests.
(Assignee)

Comment 8

6 years ago
(In reply to comment #7)
> (In reply to comment #6)
> > I don't think we need r+ for fixing a test, right?
> 
> We need r+ but not a+ for tests.

Oh yes.
Comment on attachment 532820 [details] [diff] [review]
Patch for checkin

Review of attachment 532820 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely :)
Attachment #532820 - Flags: review?(ian) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 10

6 years ago
Created attachment 533144 [details] [diff] [review]
Patch for checkin
Attachment #532820 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
http://hg.mozilla.org/mozilla-central/rev/c9413bd69b93
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.