Closed
Bug 657331
Opened 13 years ago
Closed 13 years ago
Fix the registerCleanupFunction() in browser_tabview_bug625195.js
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 6
People
(Reporter: raymondlee, Assigned: raymondlee)
References
Details
Attachments
(1 file, 2 obsolete files)
1.36 KB,
patch
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•13 years ago
|
||
Updated•13 years ago
|
Summary: Fix the registerCleanupFunction() in brobrowser_tabview_bug625195.js → Fix the registerCleanupFunction() in browser_tabview_bug625195.js
Comment 2•13 years ago
|
||
Comment on attachment 532613 [details] [diff] [review] v1 Review of attachment 532613 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks for doing this!
Attachment #532613 -
Flags: feedback?(tim.taubert) → feedback+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 532613 [details] [diff] [review] v1 Passed http://tbpl.mozilla.org/?tree=Try&rev=926cf390c679
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #532613 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to comment #5) > Sorry, I'd like to give you r+ but I can't :) I don't think we need r+ for fixing a test, right?
Assignee | ||
Updated•13 years ago
|
Attachment #532820 -
Flags: review?(ian)
Comment 7•13 years ago
|
||
(In reply to comment #6) > I don't think we need r+ for fixing a test, right? We need r+ but not a+ for tests.
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to comment #7) > (In reply to comment #6) > > I don't think we need r+ for fixing a test, right? > > We need r+ but not a+ for tests. Oh yes.
Comment 9•13 years ago
|
||
Comment on attachment 532820 [details] [diff] [review] Patch for checkin Review of attachment 532820 [details] [diff] [review]: ----------------------------------------------------------------- Lovely :)
Attachment #532820 -
Flags: review?(ian) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 10•13 years ago
|
||
Attachment #532820 -
Attachment is obsolete: true
Updated•13 years ago
|
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
Comment 11•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c9413bd69b93
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•