Closed Bug 657331 Opened 9 years ago Closed 9 years ago

Fix the registerCleanupFunction() in browser_tabview_bug625195.js

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 6

People

(Reporter: raymondlee, Assigned: raymondlee)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #532613 - Flags: feedback?(tim.taubert)
Summary: Fix the registerCleanupFunction() in brobrowser_tabview_bug625195.js → Fix the registerCleanupFunction() in browser_tabview_bug625195.js
Comment on attachment 532613 [details] [diff] [review]
v1

Review of attachment 532613 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for doing this!
Attachment #532613 - Flags: feedback?(tim.taubert) → feedback+
Depends on: 625195
Attached patch Patch for checkin (obsolete) — Splinter Review
Attachment #532613 - Attachment is obsolete: true
Keywords: checkin-needed
Sorry, I'd like to give you r+ but I can't :)
Keywords: checkin-needed
(In reply to comment #5)
> Sorry, I'd like to give you r+ but I can't :)

I don't think we need r+ for fixing a test, right?
Attachment #532820 - Flags: review?(ian)
(In reply to comment #6)
> I don't think we need r+ for fixing a test, right?

We need r+ but not a+ for tests.
(In reply to comment #7)
> (In reply to comment #6)
> > I don't think we need r+ for fixing a test, right?
> 
> We need r+ but not a+ for tests.

Oh yes.
Comment on attachment 532820 [details] [diff] [review]
Patch for checkin

Review of attachment 532820 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely :)
Attachment #532820 - Flags: review?(ian) → review+
Keywords: checkin-needed
Attachment #532820 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.