658015 - Attendees Dialog: Comma truncates attendee name

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Followup for bug 492069. When entering foo,bar in the attendee dialog, it is immediately truncated. This patch mimics the TB compose dialog behavior, where a new line is inserted for each new name on blur.

Comment 1

[Decathlon]

Comment on attachment 533371 [details] [diff] [review]
Fix - v1

The patch works fine. It divides entries with comma or semicolon.
I had some doubt about deleting the this.onModify() line, but it seems not necessary when the method appendNewRow() is being called.

r+

Philipp, what about an entry like this:

a <[e-mail]> b <[e-mail]> ?

It doesn't have so much sense, but there is an incoherent behavior because it remains the same in the Invite Attendees dialog and becomes

a <[e-mail]> b

in the Edit Event dialog (and in the exported ics file), instead is still like the original in the attendees popup menu.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Lets just go with this solution for now. I'm not sure why that happens, because I use the header parser to split into multiple addresses. If anyone wants to fix this I won't deny a patch, but its very edge case and we should put our energy into other bugs :)


the onModify function is called every second anyway, so the worst thing that could happen is a 999 ms delay, which I think is ok.

Comment 3

[Martin Schröder [:mschroeder]]

Could it be that the checkin comment has been posted as bug 492069#c27 ? So, this bug could be closed if it's true.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Yes, sorry about that!