492069 - Lightning corrupts ATTENDEE / ORGANIZER with CN parameter that contains a comma

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Bernard Desruisseaux]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.20) Gecko/20081217 Firefox/2.0.0.20 X-ORACLE-DEBUG=STATS (.NET CLR 3.5.30729)
Build Identifier: Lightning 0.9

The Invite Attendee dialog automatically removes the double quotes from the common name of attendees that were already specified in the event. In the case of an attendee with a common name value that contains a comma, the CN parameter ends up being removed, and the attendee property value is set to the text that appeared in the common name before the comma, that is, the email address of the attendee is lost.

Reproducible: Always

Steps to Reproduce:
1- Create new event

2- Click on the "Invite Attendees" button

3- Add attendee the following attendee (with this exact text):

   "a,b" <[e-mail]>

4- Click on the "Ok" button.

5- Click on the "Invite Attendees" button again

6- Notice that the attendee name is no longer specified within double quotes:

   a,b <[e-mail]>

7- Click on the "Ok" button.

8- Click on the "Save and Close" button.
Actual Results:  
Mozilla Lightning generates the following ATTENDEE property:

  ATTENDEE;RSVP=TRUE;PARTSTAT=NEEDS-ACTION;ROLE=REQ-PARTICIPANT:a

Expected Results:  
Mozilla Lightning should generate the following ATTENDEE property:

  ATTENDEE;RSVP=TRUE;CN="a,b";PARTSTAT=NEEDS-ACTION;ROLE=REQ-PARTICIPANT:
   mailto:[e-mail]

This issue will occur more frequently to users that enabled the address autocompletion feature as Lightning will automatically add the user's common name found in a local address book or in LDAP.

Comment 1

[Stefan Sitter [:ssitter]]

Are you able to reproduce the issue using Thunderbird 3 Beta 2 (or newer) together with a recent Lightning 1.0pre test build?

Comment 2

[F. G.]

Seems to be fixed.  I got (anonymized)

ATTENDEE;RSVP=TRUE;CN="Second, First";PARTSTAT=NEEDS-ACTION;ROLE=REQ-PARTICIPANT:mailto:[e-mail]

With Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.1b3pre) Gecko/20090223 Lightning/1.0pre Thunderbird/3.0b2

Comment 3

[Balaji]

I  still have the problem (even with 1.0 pre) and lightning does corrupt
the invities address and hence could not send event mail.


Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.1) Gecko/20090715 Lightning/1.0pre Thunderbird/3.0b3

Is there any work around for this .

Comment 4

[Balaji]

Just to add more information..

I added multiple invites for my event..I am not sure where to see the
Attendee property to show how it is stored. Let me know, I will do that..

regards,
Balaji

Comment 6

[Martin Schröder [:mschroeder]]

Confirmed per duplicate bug. -> NEW

Comment 7

[Decathlon]

Is this issue the same as bug 427949 (or vice versa)?

Comment 8

[Balaji]

Yes It is same as 427949. 


regards,
Balaji

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Does this still happen with the latest 1.0b3pre nightlies?

Comment 12

[Daniel Vijge]

I just tested this with Lightning/1.0b2, and the issue seems already be solved.

Comment 13

[Philipp Kewisch [:Fallen][☁️📆]]

Thanks for testing!

Comment 14

[Decathlon]

The bug is still present with the same exact steps to reproduce reported in comment #0 (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9pre) Gecko/20100808 Lightning/1.0b2pre Lanikai/3.1.3pre).

In the past I tried to look into this issue, what I found is that the parseHeadersWithArray [1] returns the |names| part without double quotes, i.e. with the attendee reported in bug description:

 "a,b" <[e-mail]>
 
the parseHeadersWithArray's output is

emailAddresses = [e-mail]
names          = a,b
fullNames      = "a,b" <[e-mail]>

and the |names| part is exactly the value assigned to the attendee's commonName property [2]

Without changing the parseHeadersWithArray's behavior, I've tried to add some code that adds double quotes if the |names| string has comma, semicolon or colon, something like the following (just before line #566):

let str = names.value[0];
if (str.search(/[,;:]/) != -1) {
    str = "\"" + str + "\"";
    names.value[0] = str;                          
}

and this would fix the part related to the UI (no more problems described in comment #0 when saving, closing or opening the dialog) because now commonName is always "a,b". Although, it doesn't solves the bug because in the ics calendar, the double quotes are added again and it results a CN property with double quotes duplicated that corrupts again the attendee:

ATTENDEE;RSVP=TRUE;CN=""a,b"";PARTSTAT=NEEDS-ACTION;ROLE=REQ-PARTICIPANT:m
 ailto:[e-mail]

These are my 2 cents.

Not sure whether this is the right approach, anyway I hope it could be useful.

[1]
http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml#544

[2] http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml#566

Comment 15

[ikke]

I confirm this long standing problem now on:

fedora-release-14-1.noarch
thunderbird-3.1.7-2.fc14.x86_64
thunderbird-lightning-1.0-0.35.b3pre.fc14.x86_64

There are lot of us in the company that this affects, since all names come back from the LDAP as in form of "surname, firstname" <[e-mail]>.

I use the following calendar setup:
 lightning <-> DavMail CalDav proxy <-> Exchange server.

Comment 16

[Maciej Grela]

Hi,

I have noticed this bug on Thunderbird 3.1.7 on Gentoo. After some hacking I managed to fix the issue by introducing the following code into the "appendAttendee" method in calendar-event-dialog-attendees.xml XUL file (found in /usr/lib/thunderbird/extensions/\{e2fda1a4-762b-4020-b5ad-a41df1933103\}/chrome/calendar.jar on my machine). Patch against latest trunk:

diff -r 78440aa35ff6 calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
--- a/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml	Mon Nov 15 18:43:19 2010 -0500
+++ b/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml	Mon Feb 07 17:59:06 2011 +0100
@@ -334,6 +334,7 @@
           var inputValue = aAttendee.commonName;
           var regexp = new RegExp("^mailto:(.*)", "i");
           if (inputValue && this.mHeaderParser) {
+	      inputValue = '"' + inputValue + '"'; // Make the commonName appear in quotes
               var email = aAttendee.id;
               if (email && email.length) {
                   if (regexp.test(email)) {



This fixes the issue when saving the ics and also sending an email to conference participants.

Comment 17

[ikke]

Thanks Maciej,

I verify this fixes it for f14 too. The patch has drifted a bit in lines, this is my manual patch with the same change:

--- content/calendar/calendar-event-dialog-attendees.xml.orig   2011-02-08 12:23:16.786034133 +0200
+++ content/calendar/calendar-event-dialog-attendees.xml        2011-02-08 12:47:39.463473538 +0200
@@ -338,6 +338,7 @@
           var regexp = new RegExp("^mailto:(.*)", "i");
           if (inputValue && this.mHeaderParser) {
               var email = aAttendee.id;
+              inputValue = '"' + inputValue + '"';
               if (email && email.length) {
                   if (regexp.test(email)) {
                       inputValue += ' <' + RegExp.$1 + '>';

Could someone please pick this patch to upstream? Decathlon's description is good one, and two of us already tested the patch to be working.

Comment 18

[Decathlon]

Seems working fine, maybe there's something to add in order to not make appear every name, even without comma, with double quotes in the attendees list.
I'm going to attach a patch.

Comment 19

[Decathlon]

Attachment: [for beta]patch based on Maciej's code

The patch is based on code from comment #16.
I've only changed the way the double quotes are added to the common name i.e. only if the name contains a comma or semicolon, otherwise every name appeared with double quotes in the attendees list.
I've done the same in the list that appears in the Event dialog.

The patch resolves completely the problem described in bug description, but I'm not completely sure if something is missing. For example, when the user inputs a name 

    a,b <[e-mail]>

(the same of the comment #0 but without double quotes), the part after the comma get immediately lost.
Philipp, what should be the behavior in this case?

I've uploaded a build for Windows if someone what to try it:
http://www.mediafire.com/file/89bfcnud1akp317/lightning1.0b3pre-20110208-Bug492069-Win.xpi
try it only on a *new profile* and *without* important data. ;-)

Comment 20

[Ronny Becker]

We had the same problem on Linux using Thunderbird 3.1.7 & 3.1.9 with Lightning 1.0b2.

The patch posted in comment 17 works for us, too.

Please apply this patch to upstream!!

Comment 21

[gaxweb]

Having the same problem with Lightning 1.0b2 and TB 3.1.9 on Win7. Also because I'm using the surname, firstname format.

Comment 22

[Dmitry Vas'kovskiy]

I have the same problem with Lightning 1.0b2 and Postbox 2.1.4

Comment 23

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/ceb7dae0c311>
-> FIXED

Comment 24

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 510643 [details] [diff] [review]
[for beta]patch based on Maciej's code

Oh, did I say r=philipp? ;-)

I have a followup patch that mimics the behavior of Thunderbird when a comma is entered. I'll upload in a moment.

Comment 25

[Philipp Kewisch [:Fallen][☁️📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/a7074bcee258>

Comment 26

[Philipp Kewisch [:Fallen][☁️📆]]

Followup bug 658015 filed with a patch, I'd appreciate if you could look into it.

Comment 27

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/8d78eb1a2172>
-> FIXED

Comment 28

[Philipp Kewisch [:Fallen][☁️📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/ade521240e4f>