658068 - Properly escape spaces in title= in atom links displayed by buglist.cgi

Status: NEW

(Bugzilla :: User Interface, defect)

Description

[David Lawrence [:dkl]]

Attachment: Patch to escape spaces in title= in the atom links of buglist.cgi (v1)

Patch attached that properly escapes spaces in the title= variable in the atom links displayed on buglist.cgi. This fixes some HTML validation issues pointed out by bug 652413.

Comment 1

[Frédéric Buclin]

Comment on attachment 533424 [details] [diff] [review]
Patch to escape spaces in title= in the atom links of buglist.cgi (v1)

wrong patch!

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to escape spaces in title= in the atom links of buglist.cgi (v2)

Ugh, Sorry. Here is the right patch with just the one file in question.

dkl

Comment 3

[Frédéric Buclin]

Comment on attachment 533434 [details] [diff] [review]
Patch to escape spaces in title= in the atom links of buglist.cgi (v2)

>-  atomlink = "buglist.cgi?$urlquerypart&title=$title&ctype=atom" 
>+  atomlink = "buglist.cgi?$urlquerypart&title=$url_filtered_title&ctype=atom" 

atomlink is already HTML-filtered in global/header.html.tmpl:

    [% IF atomlink %]
       <link rel="alternate" 
             type="application/atom+xml" title="Atom feed" 
             href="[% atomlink FILTER html %]">
    [% END %]

so your change is wrong.

Comment 4

[David Lawrence [:dkl]]

Not the way I understood the issue. The HTML validation service is complaining that the 'title' attribute has spaces in it which should instead be %20. The html filter does not convert spaces to anything but the uri filter does. That is why the patch uri filters the title only. The html filter in header.html.tmpl will handle everything else.

dkl