658680 - [shipping] remove signoff view 1

Status: VERIFIED FIXED

(Webtools Graveyard :: Elmo, defect, P1)

Description

[Axel Hecht [:Pike]]

Now that signoff2 (bug 565358) is landed, we should remove signoff 1. aka pushes.

Comment 1

[Axel Hecht [:Pike]]

Attachment: remove signoff 1 and it's helpers

Nice patch, IMHO.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 534305 [details] [diff] [review]
remove signoff 1 and it's helpers

Review of attachment 534305 [details] [diff] [review]:
-----------------------------------------------------------------

yay! excited :)

Comment 3

[Axel Hecht [:Pike]]

Attachment: update to remove flag option on dashboard

Update, I forgot to remove the optional display of the old UI in the dashboard.

Comment 4

[Peter Bengtsson [:peterbe]]

Comment on attachment 534395 [details] [diff] [review]
update to remove flag option on dashboard

Review of attachment 534395 [details] [diff] [review]:
-----------------------------------------------------------------

I looove removing stuff. My only fear is that merging my branch on externalizing embedded JS might bring some junk back if I'm not careful.

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 534395 [details] [diff] [review]
update to remove flag option on dashboard

Review of attachment 534395 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I understand it, this is good to go. r=me.  Nice job!

Comment 6

[Axel Hecht [:Pike]]

https://github.com/mozilla/elmo/commit/dc61fc85b6d5134333e72d1bf248bf766f0da40a, FIXED.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this something QA can test?

Comment 8

[Axel Hecht [:Pike]]

https://l10n-stage-sj.mozilla.org/shipping/pushes?locale=ru&av=fennec-aurora is a 404, marking VERIFIED. I guess that's as good as it gets for verifying the absence of things.