Closed Bug 658680 Opened 13 years ago Closed 13 years ago

[shipping] remove signoff view 1

Categories

(Webtools Graveyard :: Elmo, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

Details

Attachments

(1 file, 1 obsolete file)

Now that signoff2 (bug 565358) is landed, we should remove signoff 1. aka pushes.
Nice patch, IMHO.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Attachment #534305 - Flags: review?(stas)
Attachment #534305 - Flags: review?(peterbe)
Attachment #534305 - Flags: review?(gandalf)
Comment on attachment 534305 [details] [diff] [review] remove signoff 1 and it's helpers Review of attachment 534305 [details] [diff] [review]: ----------------------------------------------------------------- yay! excited :)
Attachment #534305 - Flags: review?(gandalf) → review+
Update, I forgot to remove the optional display of the old UI in the dashboard.
Attachment #534305 - Attachment is obsolete: true
Attachment #534305 - Flags: review?(stas)
Attachment #534305 - Flags: review?(peterbe)
Attachment #534395 - Flags: review?(stas)
Attachment #534395 - Flags: review?(peterbe)
Blocks: 653385
Comment on attachment 534395 [details] [diff] [review] update to remove flag option on dashboard Review of attachment 534395 [details] [diff] [review]: ----------------------------------------------------------------- I looove removing stuff. My only fear is that merging my branch on externalizing embedded JS might bring some junk back if I'm not careful.
Attachment #534395 - Flags: review?(peterbe) → review+
Priority: -- → P1
Target Milestone: --- → 1.2
Comment on attachment 534395 [details] [diff] [review] update to remove flag option on dashboard Review of attachment 534395 [details] [diff] [review]: ----------------------------------------------------------------- As far as I understand it, this is good to go. r=me. Nice job!
Attachment #534395 - Flags: review?(stas) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Is this something QA can test?
https://l10n-stage-sj.mozilla.org/shipping/pushes?locale=ru&av=fennec-aurora is a 404, marking VERIFIED. I guess that's as good as it gets for verifying the absence of things.
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: