65877 - Need an easy way to add search engines to Search Panel

Status: NEW

(SeaMonkey :: Search, enhancement)

Description

[Erich 'Ricky' Iseli]

Similarly to the "Get more themes" and "Get more sidebar tabs", Fabian
<[e-mail]> suggested to add a link to http://sherlock.mozdev.org/ in
order to provide an easy way to add more engines.

The "Get more search engines" (or similar) could be added at different places. I
don't want to exclude any at this stage, but I don't expect it either to appear
in all these places:

- Search menu, below the "My Sidebar search tab" (Similar to View|Apply
theme|Get new themes)
- on the Edit Categories dialog (opened through the search panel) (Similar to
Tabs | Customize my sidebar | Find more tabs)
- on the Edit|Preferences|Navigator|Internet search dialog

Comment 1

[Fabian Guisset]

*** Bug 65054 has been marked as a duplicate of this bug. ***

Comment 2

[wkfx2003-bugzilla]

Edit category should use "Include" and "Exclude" search engine.
instead of "Add" , "Remove"

Comment 3

[Claudius Gayle]

-->future. Todd, is this something we want to do?

Comment 4

[Todd Pringle]

Probably not anytime soon.

Comment 5

[Erich 'Ricky' Iseli]

*** Bug 127161 has been marked as a duplicate of this bug. ***

Comment 6

[R.K.Aa.]

*** Bug 145883 has been marked as a duplicate of this bug. ***

Comment 7

[julius ross]

Attachment: adds a link to "get new search engines" to preferences->navigator->internet search

I have attached a patch which adds a link in preferences->navigator->internet
search to "Get New Search Engines" which points to http://mycroft.mozdev.org

be aware - I am a complete newbie.

Comment 8

[Erich 'Ricky' Iseli]

Nice work Julius. However, in your C&P work, you forgot to change the ID

+    <html:a id="themesLink" href="&getNewSearchEnginesURL;"

suggested:

id="sherlockLink"

However I don't know if this id is used by the new stylesheet you attach

Also, I think the link to mycroft should be a special page, not the homepage.

Last but not least, as very few people are using the sidebar, this kind of link
should also be shown in Edit|Preferences|Internet Search

Comment 9

[julius ross]

> suggested: id="sherlockLink"

I want the same style for both.  Is it better to created a sherlockLink id or to
rename themesLink to "externalLink"?

>the link to mycroft should be a special page, not the homepage.

It points to the download page <http://mycroft.mozdev.org/download.html>.  Which
page do you suggest?

>this kind of link should also be shown in Edit|Preferences|Internet Search

I am not sure what you mean by this.  The patch adds a links to the search
section of the main preferences (which, for linux, is Edit|Preferences|Internet
Search). 

Comment 10

[julius ross]

I have just noticed that the getnewthemes link points to a page at mozilla.org
<http://mozilla.org/themes/download/> which links to 2 sites with themes.  

This seems unecessary here unless there is an alternative to the mycroft project.

Comment 11

[Erich 'Ricky' Iseli]

Julius,

>> suggested: id="sherlockLink"
>
> I want the same style for both.  Is it better to created a sherlockLink id or
> to rename themesLink to "externalLink"?

And ID is not that much about styling. It's an identificator. While you only use
an ID-value once on a webpage, I think it's a must in an application to have a
unique ID all over the app. This is especially useful for the skinning. And
since this link is not at all about themes, I don't think it should be called
themeslink.

In the corresponding CSS (if styling is done via the ID), you can write
#themeslink, #sherlocklink {styling-rules}

>>the link to mycroft should be a special page, not the homepage.
>
> It points to the download page <http://mycroft.mozdev.org/download.html>.
> Which page do you suggest?

I mean, maybe a new page like download-frombrowser.html. This way we could
display different things and style them differently than the download.html page.
This could be useful because as people start to link directly to the
download.html page, some visitors will get there without knowing what this page
is about. So there would be a need of a short introductory text, which would not
be needed for people coming from the browser.

>> this kind of link should also be shown in Edit|Preferences|Internet Search
>
> I am not sure what you mean by this.  The patch adds a links to the search
> section of the main preferences (which, for linux, is
> Edit|Preferences|Internet Search). 

Right. My misunderstanding. Can you read my original post and tell if there's an
easy way to add the button to the other mentioned places? Actually, since the
Search menu is gone we just would have to add it to the "Edit Categories" dialog.

Comment 12

[Sam Schinke]

http://mozdev.org/bugs/show_bug.cgi?id=2244

If mycroft can upgrade to acheive this RFE I posted for it a while back, it might be easiest if Mozilla just includes a sherlock plugin to search for sherlock plugins (a meta-sherlock plugin).

And even if it isn't the only method employed, it would still be extremely useful.

Regards,
Sam

Comment 13

[julius ross]

Attachment: adds two links to mycroft webpages

The new patch adds two links titled 'Get New Search Engines'

1. Preferences -> Internet Search
2. (As long as you are in Advanced Search Mode) Search Sidebar -> Edit
Categories

Both point to mycroft.mozdev.org/browser/download.html

This patch is the result of 
cvs -q diff -u themes xpfe 
It works with both classic and modern themes.

Comment 14

[Daniel Küstner]

This bug has a patch since 2 years. julius: did you request review?

Comment 15

[Guido Rademaker]

A variant of this bug is still present in Firefox 3.0 at 'Get more search engines', for example.