658793 - Embedded S/MIME messages are not decrypted

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Patrick Brunschwig]

Using Miramar 3.3a4 build ...

An embedded S/MIME message following the structure below is not decrypted anymore. Instead, it is displayed as attachment. Unfortunately, Enigmail relies on this scenario to work for its initialization process of PGP/MIME. This used to work until +/- May 10th.

Subject: ...
Content-Type: multipart/mixed; boundary="--MSGSEP"

This is a multi-part message in MIME format.

----MSGSEP
Content-Type: application/pkcs7-mime; name="smime.p7m"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7m"
Content-Description: S/MIME Encrypted Message

ENCRYPTED_DATA

----MSGSEP
Content-Type: text/plain

DATA

----MSGSEP--


I debugged this a bit and I found that until recently libmime produced MimeEncrypted objects for such embededded S/MIME parts (which I consider correct). But now the class type changed to MimeExternalObject.

Comment 1

[Patrick Brunschwig]

I'm pretty sure that the crash 5ee1042a-1be7-44df-b67f-a174e2110522 
is related to this problem.

Comment 2

[Magnus Melin [:mkmelin]]

From bug 243833?

Comment 3

[Patrick Brunschwig]

Yes, quite likely.

Comment 4

[[:Aureliano Buendía]]

Should be dupe of bug #655535: do you agree?

Comment 5

[Ludovic Hirlimann [:Usul]]

(In reply to comment #4)
> Should be dupe of bug #655535: do you agree?

Yep it looks like it. Patrick ?

Comment 6

[Ludovic Hirlimann [:Usul]]

Patrick how hard would it be for you to provide us with all the testcase you have/use in form of xp-shell or other testcase, so we would have a better set of unit test with regards to mime S/mime handling ?

Comment 7

[Patrick Brunschwig]

Yes, this is likely a dupe of bug #655535.

(In reply to comment #6)
> Patrick how hard would it be for you to provide us with all the testcase you
> have/use in form of xp-shell or other testcase, so we would have a better
> set of unit test with regards to mime S/mime handling ?

I will attach a complete test message to bug 655535.

Comment 8

[David :Bienvenu]

re-opening - this is different from bug 655535 - this problem message here has an actual attachhment; bug 655535 is about the case where the main message body itself is of type pkcs7-mime

Comment 9

[David :Bienvenu]

Patrick, can you attach a test message to this bug? Thx!

Comment 10

[Patrick Brunschwig]

Attachment: Test case

The attached file can be directly used as new folder, i.e. just copy the file to Local Folders and restart TB. Obviously the message is encrypted to myself, but I think it should in any case trigger an attempt to decrypt it.

Comment 11

[David :Bienvenu]

should be fixed by backout of bug 243833 - please let me know if it's not.

Comment 12

[intendentedelleacque]

(In reply to comment #10)
> Created attachment 534487 [details]
> Test case
> 
> The attached file can be directly used as new folder, i.e. just copy the
> file to Local Folders and restart TB. Obviously the message is encrypted to
> myself, but I think it should in any case trigger an attempt to decrypt it.

I don't understand how can be used this TestCase: if i try to see this message, I don't see any attachment and there is no attempt to decrypt it.
All I can see is the text "Some test Text".
If I enable the "Smart P7M Support" extension, I can see a smime.p7m attachment.