Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Intermittent browser_tabview_bug624265.js | There is one single groupItem - Got 2, expected 1

RESOLVED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: dao, Assigned: ttaubert)

Tracking

({intermittent-failure})

Trunk
Firefox 7
x86
Mac OS X
intermittent-failure
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1306093221.1306094641.5628.gz

Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other

s: talos-r3-leopard-004
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624265.js | There is one single groupItem - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624727.js | start: there are 1 groups - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624727.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624727.js | Found a tab after previous test timed out: about:blank
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624727.js | Found a tab after previous test timed out: about:blank
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624727.js | Found a tab after previous test timed out: about:blank
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624847.js | start: there should be 1 groups - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624847.js | unpinned-restored: there should be 1 groups - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624847.js | pinned-restored: there should be 1 groups - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624847.js | finish: there should be 1 groups - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug625195.js | Has one group only - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug628270.js | start: there are 1 groups - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug628270.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug628270.js | Found a tab after previous test timed out: http://mochi.test:8888/
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug628270.js | Found a tab after previous test timed out: http://mochi.test:8888/
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js | There is only one group item - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630157.js | there should be 2 groups - Got 3, expected 2
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630157.js | there should be 1 groups - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug635696.js | there is one groupItem - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug640765.js | Has only one group - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug641802.js | there is one groupItem - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug641802.js | there is one groupItem - Got 2, expected 1
Comment hidden (Treeherder Robot)
(Assignee)

Updated

6 years ago
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Comment hidden (Treeherder Robot)
(Assignee)

Comment 3

6 years ago
Created attachment 534387 [details] [diff] [review]
patch v1
Comment hidden (Treeherder Robot)
(Assignee)

Comment 5

6 years ago
Created attachment 534394 [details] [diff] [review]
patch v2
Attachment #534387 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Blocks: 656075
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 8

6 years ago
Comment on attachment 534394 [details] [diff] [review]
patch v2

* Hardening restoreTab() in case the tab has already been reconnected.
* Making sure to not switch private browsing mode if we're still in the same execution context that notified us about the PB mode transition.
Attachment #534394 - Flags: review?(ehsan)
(Assignee)

Comment 9

6 years ago
Comment on attachment 534394 [details] [diff] [review]
patch v2

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=940d4dfb9ec0
(Assignee)

Updated

6 years ago
Blocks: 658832
(Assignee)

Updated

6 years ago
Attachment #534394 - Flags: feedback?(raymond)
Comment on attachment 534394 [details] [diff] [review]
patch v2

Looks good!
Attachment #534394 - Flags: feedback?(raymond) → feedback+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Attachment #534394 - Flags: review?(ehsan) → review+
(Assignee)

Comment 13

6 years ago
http://hg.mozilla.org/mozilla-central/rev/503990b2c5c6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Keywords: intermittent-failure
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.