659055 - unpowered users unable to nominate for blocking

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Daniel Veditz [:dveditz]]

People are reporting that they can no longer nominate a bug for blocking a release (by setting the custom flag-like field to '?'). They can do so when filing a new bug, but not on an existing bug.

People with the power to set those fields to plus or minus can still nominate, but there's no way for the community to raise the visibility of bugs to the release triage teams.

Here's the relevant dev.planning thread:
https://groups.google.com/forum/#!topic/mozilla.dev.planning/3X2Ej2Yn0Rg

Affects all of the fields:
  tracking-fennec
  tracking-firefox5
  tracking-firefox6
  blocking2.0
  blocking1.9.2
  blocking1.9.1

It's possible there was a project management decision to do nominations a different way for Firefox5/6/Fennec, in which case I'd like to keep this bug open for the older blocking flags which I triage and still need. (We need to decide when to deactivate 2.0/1.9.1, but we'll keep it available at least until the next 3.6.x/5.0 releases).

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to fix flag nomination by certain users (v1)

Patch that fixes bug with flag nomination by certain users.

dkl

Comment 2

[:glob ✱]

Comment on attachment 534517 [details] [diff] [review]
Patch to fix flag nomination by certain users (v1)

Review of attachment 534517 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: extensions/BMO/Extension.pm
@@ +273,5 @@
>      # Purpose: Only users in the appropriate drivers group can change the 
>      # cf_blocking_* fields or cf_tracking_* fields
>      if ($field =~ /^cf_(?:blocking|tracking)_/) {
> +        # 1 -> 0 is used by show_bug, always allow so we skip this whole part
> +        if (!($new_value eq '1' && $old_value eq '0')) {

nit: comment should say 0 -> 1

Comment 3

[David Lawrence [:dkl]]

Thanks. We will push this live as soon as IT can get to it.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/BMO/Extension.pm
Committed revision 7716.

dkl

Comment 4

[Dave Miller [:justdave]]

this is live in production now.