Package name should be stored in revision

RESOLVED FIXED in Builder 0.9.6

Status

P1
blocker
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: smcarthur, Assigned: zalun)

Tracking

unspecified
Builder 0.9.6

Details

(Reporter)

Description

8 years ago
If an Addon or Library includes another library as a dependency, it can do require('library/module'). With the name being stored in the package, it's possible for the library owner to change the name, and it will break all users using the package name in the require statements.

Instead, the name should be saved into the revision, so that way if the owner ever changes the name, it wont change for users of that library until they update to the newest revision.
(Reporter)

Updated

8 years ago
Assignee: nobody → zaloon
Severity: normal → major
Priority: -- → P1
Target Milestone: --- → Builder 0.9.6
(Reporter)

Updated

8 years ago
Severity: major → blocker
(Assignee)

Comment 1

8 years ago
Done - https://github.com/mozilla/FlightDeck/commit/7126afcbc0463275a4cc2021da91a53893299f5d

There is still a need to change the updated dependency name after it's name been changed and updated to the latest version. This wasn't working before. I marked it with XXX in Sidebar.js
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.