Closed
Bug 659707
Opened 14 years ago
Closed 14 years ago
Add -Wdeclaration-after-statement to CFLAGS
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla7
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Having this could have helped prevent that backout that happened for bug 658351.
|
Assignee | |
Comment 1•14 years ago
|
||
MSVC doesn't like declarations after statements so we should warn on other platforms too.
Attachment #535133 -
Flags: review?(khuey)
Comment on attachment 535133 [details] [diff] [review]
Add -Wdeclaration-after-statement to CFLAGS
Is the goal here to warn in gcc so that devs using gcc only don't break MSVC?
Attachment #535133 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Comment on attachment 535133 [details] [diff] [review] [review]
> Add -Wdeclaration-after-statement to CFLAGS
>
> Is the goal here to warn in gcc so that devs using gcc only don't break MSVC?
Yes.
Ship it!
|
|
Assignee | |
Comment 5•14 years ago
|
||
|
||
Comment 6•14 years ago
|
||
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
|
||
Comment 7•14 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0
Is there any way to verify this on the QA side? I checked in the repo and "Wdeclaration-after-statement" was adeed to CFLAGS:
http://hg.mozilla.org/mozilla-central/file/cc1e08803869/configure.in
Is that enough to mark this as Verified?
Thanks!
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•