659707 - Add -Wdeclaration-after-statement to CFLAGS

Status: RESOLVED FIXED

Description

[Jeff Muizelaar [:jrmuizel]]

Having this could have helped prevent that backout that happened for bug 658351.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Created attachment 535133 [details] [diff] [review]
Add -Wdeclaration-after-statement to CFLAGS

MSVC doesn't like declarations after statements so we should warn on other platforms too.

Comment 2

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 535133 [details] [diff] [review]
Add -Wdeclaration-after-statement to CFLAGS

Is the goal here to warn in gcc so that devs using gcc only don't break MSVC?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #2)
> Comment on attachment 535133 [details] [diff] [review] [review]
> Add -Wdeclaration-after-statement to CFLAGS
> 
> Is the goal here to warn in gcc so that devs using gcc only don't break MSVC?

Yes.

Comment 4

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Ship it!

Comment 5

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b47d5dcdc340

Comment 6

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/b47d5dcdc340

Comment 7

[Simona Badau [Away. Please needinfo? Alin Deac [:alindeac]]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0

Is there any way to verify this on the QA side? I checked in the repo and "Wdeclaration-after-statement" was adeed to CFLAGS:
http://hg.mozilla.org/mozilla-central/file/cc1e08803869/configure.in

Is that enough to mark this as Verified?

Thanks!