818611 - gtk2xtbin.c:478:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement ]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Filing bug on build warning:
{
widget/gtkxtbin/gtk2xtbin.c:478:5: warning: ISO C90 forbids mixed declarations and code [-pedantic]
}

This is in code added for bug 544088.

Comment 1

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Attachment: fix

Trivial fix -- just declare the variable at the beginning of the block.  I also fixed up some whitespace oddness in contextual code.

Comment 2

[Karl Tomlinson (:karlt)]

The change looks fine, but mixed declarations are permitted in C99.
Would it make more sense to add -Wno-declaration-after-statement?
See -Wdeclaration-after-statement at http://gcc.gnu.org/onlinedocs/gcc-4.5.4/gcc/Warning-Options.html

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 688883 [details] [diff] [review]
fix

Oh, I see bug 659707 and it is not worth playing with flags in non-MSVC code.

Comment 4

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/326520e22222

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/326520e22222