659746 - Have the space key scroll the thread summary as well

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, enhancement)

Description

[Jonathan Protzenko [:protz]]

Attachment: Pretty basic patch

Full disclosure: I'm actually doing this to have Thunderbird Conversations not break the space key <https://github.com/protz/GMail-Conversation-View/issues/146>. What the patch does is make the space key scroll down the multimessage (if activated) before moving on to the next unread message.

This is (imho) a minor improvement for Thunderbird, but when thunderbird conversations is installed, it makes the space key scroll down the conversation as well, before jumping to the next unread message.

The bad thing is that when jumping to the next unread message, Thunderbird expands the thread the message belongs to, and just selects that message, instead of just selecting a collapsed thread. But that's another issue.

Blake, I'm requesting review from you because I've been bothering Standard8 a lot lately. It's a very short patch, and it does the readability tweaks I mentioned over IRC earlier today.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 535169 [details] [diff] [review]
Pretty basic patch

Review of attachment 535169 [details] [diff] [review]:
-----------------------------------------------------------------

Well, I've looked and looked for something I could complain about with this patch, but the code seems great, and the ux is better than what we've got now, so ui-r=me and r=me.

Congrats,
Blake.

Comment 2

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/a8ac500e3a6f