659832 - Make WebGL working on Maemo

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

I tried offscreenFBO on maemo6, latest SGX version and it does not render anything, last time we tried to found where is the problem and that was some drivers problem.

Here is the patch which is making EGL context init for content process working, also it switching maemo WebGL surface into to use GLContext bounded to XSurface, and related resizing changes.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: WebGL initialization fix for Maemo

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 535240 [details] [diff] [review]
WebGL initialization fix for Maemo

Review of attachment 535240 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/GLContextProviderEGL.cpp
@@ +629,5 @@
> +                                             cxattribs);
> +        if (!context) {
> +            if (shareContext) {
> +                shareContext = nsnull;
> +                goto TRY_AGAIN_NO_SHARING;

I'd rather two separate calls to eglCreateContext than this goto. (I understand that you're just factoring out code, but we may as well make it prettier while we're at it! :) )

@@ +1806,2 @@
>  
> +    if (!glContext->Init()) {

This is already done in GLContextEGL, so I don't think it's necessary, right?

@@ +2087,5 @@
>      EGLSurface surface = 0;
>      EGLConfig config = 0;
>  
>  #ifdef MOZ_X11
> +    surface = CreateEGLSurfaceForXSurface(thebesSurface, &config, gUseBackingSurface ? 16 : 0);

Is there no way to get the bit-depth in a more portable way? EGL might not always be 16-bit only.

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Fixed comments

Comment 4

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/1619d8fc6416