The default bug view has changed. See this FAQ.

Make WebGL working on Maemo

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
ARM
MeeGo
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
I tried offscreenFBO on maemo6, latest SGX version and it does not render anything, last time we tried to found where is the problem and that was some drivers problem.

Here is the patch which is making EGL context init for content process working, also it switching maemo WebGL surface into to use GLContext bounded to XSurface, and related resizing changes.
(Assignee)

Comment 1

6 years ago
Created attachment 535240 [details] [diff] [review]
WebGL initialization fix for Maemo
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #535240 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #535240 - Flags: review? → review?(joe)
Comment on attachment 535240 [details] [diff] [review]
WebGL initialization fix for Maemo

Review of attachment 535240 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/GLContextProviderEGL.cpp
@@ +629,5 @@
> +                                             cxattribs);
> +        if (!context) {
> +            if (shareContext) {
> +                shareContext = nsnull;
> +                goto TRY_AGAIN_NO_SHARING;

I'd rather two separate calls to eglCreateContext than this goto. (I understand that you're just factoring out code, but we may as well make it prettier while we're at it! :) )

@@ +1806,2 @@
>  
> +    if (!glContext->Init()) {

This is already done in GLContextEGL, so I don't think it's necessary, right?

@@ +2087,5 @@
>      EGLSurface surface = 0;
>      EGLConfig config = 0;
>  
>  #ifdef MOZ_X11
> +    surface = CreateEGLSurfaceForXSurface(thebesSurface, &config, gUseBackingSurface ? 16 : 0);

Is there no way to get the bit-depth in a more portable way? EGL might not always be 16-bit only.
Attachment #535240 - Flags: review?(joe) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 538308 [details] [diff] [review]
Fixed comments
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/1619d8fc6416
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

5 years ago
Duplicate of this bug: 580601
You need to log in before you can comment on or make changes to this bug.