Closed Bug 660331 Opened 14 years ago Closed 14 years ago

Create method for triggering perf test

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Product:
addons.mozilla.org Graveyard
Component:
Developer Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: clouserw, Assigned: kumar)

Details

Alice documented the API end point for triggering performance testing. This bug is for creating a method so we can start testing this. We don't need any UI yet - this can be all command line for now. The docs are here: https://intranet.mozilla.org/Anodelman:doc:TriggerSendchange Let us know if there are any questions on interaction or design
What URL is trigger.cgi currently available on while we test?
If Alice doesn't have something to hit yet just mock responses in your tests
Target Milestone: 6.1.0 → 6.1.1
Assignee: kumar.mcmillan → amckay
whoops, I forgot to mention that I have a patch for this, it just needs one more test. I'll post it for review asap. I had to set it aside during the scramble of firefox 6 compatibility.
Assignee: amckay → kumar.mcmillan
andym: r? https://github.com/kumar303/zamboni/compare/master...addon-perf
Target Milestone: 6.1.1 → 6.1.0
Target Milestone: 6.1.0 → 6.1.1
Implemented in https://github.com/jbalogh/zamboni/commit/fdee331 but this hasn't been run against a staging service yet.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Looking over the code, since I don't have a test system yet to put this up against, you can't depend on just having a SENDCHANGE token in the results to count as success. SENDCHANGE just indicates the message from the buildbot master as a result of a sendchange command. Here's an example of a failure message: SENDCHANGE: change(s) NOT sent, something went wrong: [Failure instance: Traceback (failure with no frames): <class 'twisted.internet.error.ConnectionRefusedError'>: Connection was refused by other side: 111: Connection refused. ] You really want to check for: SENDCHANGE: change sent successfully That is the only message that indicates that the sendchange is now actively in the system.
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Target Milestone: 6.1.1 → 6.1.0
Thanks Alice, good catch. Fixed in https://github.com/jbalogh/zamboni/commit/81e898c I'm sure we'll run into more issues once we start integrating deeper.
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.