660509 - Trim all trailing spaces in Panorama source files

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

When I attempted to create a minor patch for a Panorama bug, it resulted in many changes due to trailing spaces trimmed automatically by my editor. Trailing spaces in source files are harmful.

Reproducible: Always

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Yep, let's do that. It's painful once and we're losing some "hg blame" information and some patches will bitrot but if that makes contributing easier this sounds sane.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)

Comment 3

[Andres Hernandez [:andreshm]]

Attachment: Removed all trailing spaces

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 604189 [details] [diff] [review]
Removed all trailing spaces

Review of attachment 604189 [details] [diff] [review]:
-----------------------------------------------------------------

Can't believe I was in favor of doing this months ago. I think this makes us lose way too much blame information and we'd have to do this periodically because there can always be some patches introducing trailing spaces. Everyone should have an editor that removes trailing spaces in lines you actually changed but editors that just do it for the whole file are nuts. Sorry that I didn't close this bug earlier but thank you anyway for doing it!