660569 - Settings missing their checkbox in Gingerbread theme

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Aaron Train [:aaronmt]]

Attachment: Preferences

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110529 Firefox/7.0a1 Fennec/7.0a1

The following changeset [1] contains modifications to the Gingerbread theme which landed patches from Bug 659457. 

[1] http://hg.mozilla.org/mozilla-central/rev/113014cf801a

Preferences are missing their checkboxes, see attached screenshot.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Ugh. I renamed the check images to use hdpi, but I didn't clobber my local build so the old *-46.png images were still in my APK - which made the CSS error go unnoticed.

I also noticed one of the tab background images was renamed incorrectly and was therefore never updated. That is fixed too.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch v2

Minus the debug cruft. I am going to land this as theme bustage, but still want a review in case I need any other fixes.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mozilla-central/rev/c0e8a86aec43

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 536000 [details] [diff] [review]
patch v2

Review of attachment 536000 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 5

[Aaron Train [:aaronmt]]

Verified fixed:

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110530 Firefox/7.0a1 Fennec/7.0a1

http://hg.mozilla.org/mozilla-central/rev/c0e8a86aec43

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 536000 [details] [diff] [review]
patch v2

needed for the gingerbread on aurora stuff

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/14e3dc647d76