Closed Bug 660569 Opened 10 years ago Closed 10 years ago

Settings missing their checkbox in Gingerbread theme

Categories

(Firefox for Android Graveyard :: General, defect, P1)

ARM
Android

Tracking

(firefox6 fixed, fennec6+)

VERIFIED FIXED
Firefox 6
Tracking Status
firefox6 --- fixed
fennec 6+ ---

People

(Reporter: aaronmt, Assigned: mfinkle)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Attached image Preferences
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110529 Firefox/7.0a1 Fennec/7.0a1

The following changeset [1] contains modifications to the Gingerbread theme which landed patches from Bug 659457. 

[1] http://hg.mozilla.org/mozilla-central/rev/113014cf801a

Preferences are missing their checkboxes, see attached screenshot.
Severity: normal → major
Attached patch patch (obsolete) — Splinter Review
Ugh. I renamed the check images to use hdpi, but I didn't clobber my local build so the old *-46.png images were still in my APK - which made the CSS error go unnoticed.

I also noticed one of the tab background images was renamed incorrectly and was therefore never updated. That is fixed too.
Assignee: nobody → mark.finkle
Attachment #535999 - Flags: review?
Attached patch patch v2Splinter Review
Minus the debug cruft. I am going to land this as theme bustage, but still want a review in case I need any other fixes.
Attachment #535999 - Attachment is obsolete: true
Attachment #535999 - Flags: review?
Attachment #536000 - Flags: review?(mbrubeck)
http://hg.mozilla.org/mozilla-central/rev/c0e8a86aec43
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 536000 [details] [diff] [review]
patch v2

Review of attachment 536000 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #536000 - Flags: review?(mbrubeck) → review+
Verified fixed:

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110530 Firefox/7.0a1 Fennec/7.0a1

http://hg.mozilla.org/mozilla-central/rev/c0e8a86aec43
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 7
Comment on attachment 536000 [details] [diff] [review]
patch v2

needed for the gingerbread on aurora stuff
Attachment #536000 - Flags: approval-mozilla-aurora?
Attachment #536000 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: Firefox 7 → Firefox 6
You need to log in before you can comment on or make changes to this bug.