Settings missing their checkbox in Gingerbread theme

VERIFIED FIXED in Firefox 6

Status

Fennec Graveyard
General
P1
major
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: aaronmt, Assigned: mfinkle)

Tracking

({regression})

Trunk
Firefox 6
ARM
Android
regression

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 535985 [details]
Preferences

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110529 Firefox/7.0a1 Fennec/7.0a1

The following changeset [1] contains modifications to the Gingerbread theme which landed patches from Bug 659457. 

[1] http://hg.mozilla.org/mozilla-central/rev/113014cf801a

Preferences are missing their checkboxes, see attached screenshot.
(Reporter)

Updated

6 years ago
Severity: normal → major
Created attachment 535999 [details] [diff] [review]
patch

Ugh. I renamed the check images to use hdpi, but I didn't clobber my local build so the old *-46.png images were still in my APK - which made the CSS error go unnoticed.

I also noticed one of the tab background images was renamed incorrectly and was therefore never updated. That is fixed too.
Assignee: nobody → mark.finkle
Attachment #535999 - Flags: review?
Created attachment 536000 [details] [diff] [review]
patch v2

Minus the debug cruft. I am going to land this as theme bustage, but still want a review in case I need any other fixes.
Attachment #535999 - Attachment is obsolete: true
Attachment #535999 - Flags: review?
Attachment #536000 - Flags: review?(mbrubeck)
http://hg.mozilla.org/mozilla-central/rev/c0e8a86aec43
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 536000 [details] [diff] [review]
patch v2

Review of attachment 536000 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #536000 - Flags: review?(mbrubeck) → review+
(Reporter)

Comment 5

6 years ago
Verified fixed:

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110530 Firefox/7.0a1 Fennec/7.0a1

http://hg.mozilla.org/mozilla-central/rev/c0e8a86aec43
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 7
Comment on attachment 536000 [details] [diff] [review]
patch v2

needed for the gingerbread on aurora stuff
Attachment #536000 - Flags: approval-mozilla-aurora?
Attachment #536000 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/14e3dc647d76
tracking-fennec: --- → 6+
status-firefox6: --- → fixed
Target Milestone: Firefox 7 → Firefox 6
You need to log in before you can comment on or make changes to this bug.