Closed Bug 659457 Opened 12 years ago Closed 12 years ago

Update Gingerbread UI for Preferences/Downloads/Addons and Context Menu


(Firefox for Android Graveyard :: General, defect)

Not set


(firefox6 fixed, fennec6+)

Firefox 6
Tracking Status
firefox6 --- fixed
fennec 6+ ---


(Reporter: ibarlow, Assigned: mfinkle)




(2 files)

Now that we have a solid first cut of our Gingerbread UI, we should go in and detail some of the other areas like Preferences and the Context Menu. Some mocks below for reference:
Attached file Assets for Preferences
Included here are a dropdown button, radio buttons, and an "update addons" button!

Also, here is where we ended up with the Add-ons page update (which will change a bit once we have a discopane)
Attached patch patchSplinter Review
This patch adds nearly all CSS based changes we can make, including:
* Use black background (white text) for all richlistbox
* Uses a radio image and not the check image for popup menulist selection
* Uses a checkbox, not a toggle in prefs and about:config
* Aligned images and text to top of larry (bug 659447)
* Changed the prefs and add-ons header colors (text / background)

New files:
* gingerbread/forms.css (copied and edited from core theme)
* radio selected/unselected PNGs
* content.css and gingerbread/content.css (moved and tweaked from chrome/content/content.css)

Replaced files:
* lock and unlocked PNGs used in larry (bug 659447)
* tab background assets (bug 659447)
* close button assets (bug 659447)

Non-CSS changes:
* Makes the popup list for menulist selection popup 80% of window width instead of only wide enough. It was too cramped. This affects all themes.
Assignee: nobody → mark.finkle
Attachment #535478 - Flags: review?(mbrubeck)
Comment on attachment 535478 [details] [diff] [review]

Review of attachment 535478 [details] [diff] [review]:
Attachment #535478 - Flags: review?(mbrubeck) → review+
I noticed one problem while testing this - checkboxes move by a pixel or two when you click them, and don't move back until they are unfocused.
(In reply to comment #4)
> I noticed one problem while testing this - checkboxes move by a pixel or two
> when you click them, and don't move back until they are unfocused.

Thanks. Fixed it locally by using a transparent border on focus for the checkbox label, which we don't use but is still "there". The original patch removed the border, causing the "shift".
Depends on: 660569
Depends on: 660570
Depends on: 660571
Depends on: 660573
Comment on attachment 535478 [details] [diff] [review]

low-risk, android only, been baking on trunk for a while and vastly improves the gingerbread theme
Attachment #535478 - Flags: approval-mozilla-aurora?
forgot to note this:
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Attachment #535478 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: Firefox 7 → Firefox 6

Mozilla/5.0 (Android; Linux armv71; rv6.0a2) Gecko/20110623 Firefox/6.0a2 Fennec/6.0a2
Device: HTC Flyer
OS: Android 2.3
You need to log in before you can comment on or make changes to this bug.