Awesomebar, Bookmarks and History panes have different visual appearance in contrast to other panes in Gingerbread theme

VERIFIED FIXED in Firefox 7

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: aaronmt, Assigned: mfinkle)

Tracking

({regression})

Trunk
Firefox 7
ARM
Android
regression
Dependency tree / graph

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 535986 [details]
Bookmarks pane

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110529 Firefox/7.0a1 Fennec/7.0a1

The following changeset [1] contains modifications to the Gingerbread theme which landed patches from Bug 659457. 

[1] http://hg.mozilla.org/mozilla-central/rev/113014cf801a

The bookmark pane is not consistent in appearance with the other panes; see attached screenshot.
(Assignee)

Updated

6 years ago
Duplicate of this bug: 660571
(Assignee)

Updated

6 years ago
Summary: Bookmarks pane has different visual appearance in contrast to other panes in Gingerbread theme → Awesomebar, Bookmarks and History panes have different visual appearance in contrast to other panes in Gingerbread theme
This affects the entire Awesomescreen
Created attachment 536006 [details] [diff] [review]
wip

This converts the awesomescreen (all pages, bookmarks, history, remote tabs) to gingerbread white-on-black theme..

There are some colors I need UX help:
* The blue subtitles look bad. I made them white for now
* Badge is still white-on-red
* "star" and"remote" lucky charm images in awesomescreen "all pages" might be too gray (dark) now

Screenies coming
Assignee: nobody → mark.finkle
Created attachment 536007 [details]
all pages
Created attachment 536008 [details]
bookmarks
Created attachment 536009 [details]
history

Comment 7

6 years ago
We need to show come consistency here with the rest of the users browsing experience. To switch from a light background to a dark background is not good for the anyone's eyes. While I understand trying to match the default OS's settings, however we cannot do so at the detriment of our own usability.
No please - I don't want the awesomescreen lists to have black backgrounds. To many of the recognizable elements you expect in a web-browser (favicons, blue links, etc.) just don't work on a dark background like that.

As to the consistency argument, prefs screens across pretty much all of android have black backgrounds, so changing our prefs/downloads/add-ons screens is a reasonable compromise (they also look just fine on a black background).  Many apps keep a brighter white or light gray background for the lists that are their primary content -- see Twitter, Gmail, etc.  Awesomescreen content is primary for us.
To be clear - all the lists in the awesomescreen (all, bookmarks, history, desktop) should have white backgrounds, as in v4.
Created attachment 536327 [details] [diff] [review]
patch

This patch does a few things:
* Keeps the awesomescreen panels black-on-white
* Changes the selection color to the Android "orange"
* Cleanup the "disabled" text color for buttons and add-on items
* Cleanup some hardcoded color: #000 and background-color: #fff by making an "inverse" set of defines
Attachment #536006 - Attachment is obsolete: true
Attachment #536007 - Attachment is obsolete: true
Attachment #536008 - Attachment is obsolete: true
Attachment #536009 - Attachment is obsolete: true
Attachment #536327 - Flags: review?(21)
I wonder if this might be a good place to use system colors now? We seem to support highlight and highlight-text on my phone (and its orangish).
Comment on attachment 536327 [details] [diff] [review]
patch

Review of attachment 536327 [details] [diff] [review]:
-----------------------------------------------------------------

Nice "grey", "gray", "#aaa", lightgrey clean up.

Asking the same question as Wes, why can't we use the system highlight color? Is it because we use custom colors for the rest of the theme and you are afraid of having a dark highlight on a dark theme if someone has a custom theme?

r+ with question answered

::: mobile/themes/core/gingerbread/browser.css
@@ +655,2 @@
>  }
>  

I wonder if this will have an impact on the bookmark-edit panel that is shown when tapping on the "edit" button of the star button popup?

@@ +766,2 @@
>  }
>  

???

@@ +859,1 @@
>  }

Why do you hardcode "white" in many places but not here?

::: mobile/themes/core/gingerbread/platform.css
@@ +321,3 @@
>    background-image: url("chrome://browser/skin/images/toggle-on.png");
>  }
>  

what does "???" means?
Attachment #536327 - Flags: review?(21) → review+
(In reply to comment #11)
> I wonder if this might be a good place to use system colors now? We seem to
> support highlight and highlight-text on my phone (and its orangish).

system colors will be the next step. we are not sure how do make sure some themes use the system colors and some themes don't

right now, we use prefs (in mobile.js) to kill the system colors. when we stop doing that, there might be fallout in other themes.
Comment on attachment 536327 [details] [diff] [review]
patch

Review of attachment 536327 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/themes/core/gingerbread/browser.css
@@ +655,2 @@
>  }
>  

won't affect the dialog. only affects the richlistbox.

@@ +766,2 @@
>  }
>  

I want to remove that line. thanks.

@@ +859,1 @@
>  }

oops. I will update
pushed
http://hg.mozilla.org/mozilla-central/rev/7ade051d8cee
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 16

6 years ago
Looks great!

Verified fixed:
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110601 Firefox/7.0a1 Fennec/7.0a1
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 7
(Reporter)

Updated

6 years ago
Depends on: 661284
Comment on attachment 536327 [details] [diff] [review]
patch

low-risk, android only, been baking on trunk for a while and vastly improves the gingerbread theme
Attachment #536327 - Flags: approval-mozilla-aurora?
Attachment #536327 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/366bc7bef8f1
tracking-fennec: --- → 6+
status-firefox6: --- → fixed
You need to log in before you can comment on or make changes to this bug.