Don't show progress indicators when using bfcache to go to another page

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
From Bug 310738

> When the status bar is enabled, back/forward using bfcache does not work as
> fast as when it is disabled.
(Assignee)

Comment 1

8 years ago
Created attachment 536063 [details] [diff] [review]
Patch v1.0

I don't see any difference in the UI frankly. Presumably back in 2008 it was more noticeable since the progress was a performance hog.
Attachment #536063 - Flags: review?(neil)
Comment on attachment 536063 [details] [diff] [review]
Patch v1.0

>+      if (!(aStateFlags & nsIWebProgressListener.STATE_RESTORING)) {
>+        this._busyUI = true;
I don't think we need to go to all that trouble, just don't turn on the throbber or the progress meter.
(Assignee)

Comment 3

8 years ago
Created attachment 536846 [details] [diff] [review]
Patch v1.1 Minimal patch.

> neil@parkwaycc.co.uk      2011-05-30 06:34:56 PDT
> 
>>+      if (!(aStateFlags & nsIWebProgressListener.STATE_RESTORING)) {
>>+        this._busyUI = true;
> I don't think we need to go to all that trouble, just don't turn on the throbber or the progress meter.
Fixed.
Attachment #536063 - Attachment is obsolete: true
Attachment #536063 - Flags: review?(neil)
Attachment #536846 - Flags: review?(neil)
Attachment #536846 - Flags: review?(neil) → review+
(Assignee)

Comment 4

8 years ago
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/00d0a464d61e
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Depends on: 749893
You need to log in before you can comment on or make changes to this bug.