modules should use mozilla::Preferences

RESOLVED FIXED in mozilla7

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 536254 [details] [diff] [review]
Patch v1.0
Attachment #536254 - Flags: review?(roc)
Comment on attachment 536254 [details] [diff] [review]
Patch v1.0

Review of attachment 536254 [details] [diff] [review]:
-----------------------------------------------------------------

So imglib doesn't unregister its observers either? Would be nice to fix :-)
Attachment #536254 - Flags: review?(roc) → review+
(In reply to comment #1)
> So imglib doesn't unregister its observers either? Would be nice to fix :-)

Hmm... I have no idea to unregister it. Looks like imgRequest isn't singleton. The first instance registers an observer as strong. The observer is destroyed by nsPrefBranch at XPCOM shutdown. So, it doesn't make sense to remove the observer from its destructor.
Attachment #536254 - Flags: review?(joe)
Attachment #536254 - Flags: review?(tglek)
Comment on attachment 536254 [details] [diff] [review]
Patch v1.0

Review of attachment 536254 [details] [diff] [review]:
-----------------------------------------------------------------

I like it!

::: modules/libpr0n/src/imgLoader.cpp
@@ +914,2 @@
>  {
> +  NS_ASSERTION(Preferences::GetRootBranch(), "Pref branch is null");

You could just drop this assertion entirely, IMO.
Attachment #536254 - Flags: review?(joe) → review+
Created attachment 538403 [details] [diff] [review]
Patch v1.1
Attachment #536254 - Attachment is obsolete: true
Attachment #536254 - Flags: review?(tglek)
Attachment #538403 - Flags: review?(tglek)

Updated

6 years ago
Attachment #538403 - Flags: review?(tglek) → review+
http://hg.mozilla.org/mozilla-central/rev/3f771ec754bb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7

Updated

6 years ago
Depends on: 665388
Verified that the following files are updated un mozilla-central repository:
modules/libjar/nsJARChannel.cpp
modules/libpr0n/src/DiscardTracker.cpp
modules/libpr0n/src/imgLoader.cpp
modules/libpr0n/src/imgLoader.h
modules/libpr0n/src/imgRequest.cpp

Is this enough in order to verfy the fix and mark the bug accordingly?

Thank you!
You need to log in before you can comment on or make changes to this bug.