Closed Bug 660809 Opened 8 years ago Closed 8 years ago
about:license on Thunderbird
Steps to Reproduce: 1. Start Thunderbird 2. Help -> About Shredder 3. apear about dialog 4. click "Licensing Information" 5. Opan about:license on new tab 6. Click "Mozilla Public License" link on about:license Actual Results: Apear "Lanch Application" Expected Results: Jamp to Mozilla Public License(#mpl)
This fixes both this and bug 659527. I did a cut-down function so that we could use the specialTabs.aboutClickHandler, and made sure we'd covered all the links. I tested the manual download link changes by replacing "noUpdatesFound" in onCheckComplete with "manualUpdate" and "downloadFailed".
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #537792 - Flags: review?(jonathan.protzenko)
Attachment #537792 - Flags: review?(jonathan.protzenko) → review-
Oh and I tested this of course and this fixes both this bug and bug 659527
Comment on attachment 537792 [details] [diff] [review] The fix (for Miramar/Aurora) I'm appealing ;-) I agree with re-using the function, but I think for Miramar, and possibly Aurora, I don't want to change that function definition in utilityOverlay. Whilst I suspect no add-ons are using it yet, I'd just prefer not to just in case.
Comment on attachment 537792 [details] [diff] [review] The fix (for Miramar/Aurora) Alright :-). Can you create a followup bug for factoring the two functions? You can assign to me if you wish.
Attachment #537792 - Flags: review?(jonathan.protzenko) → review+
Filed bug 663112 on the follow-up. Checked in: http://hg.mozilla.org/comm-central/rev/08be6ad1285b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
Checked into comm-miramar: http://hg.mozilla.org/releases/comm-miramar/rev/d29fdf070fe0
Thanks for fixing this. cannot reproduce with : Shredder-20110611/WinVista, WinXP Miramar-20110612/WinVista
Status: RESOLVED → VERIFIED
Checked into aurora: http://hg.mozilla.org/releases/comm-aurora/rev/45330ef6aa2a
Attachment #537792 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.