660809 - about:license on Thunderbird

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[baffclan]

Steps to Reproduce:
1. Start Thunderbird
2. Help -> About Shredder
3. apear about dialog
4. click "Licensing Information"
5. Opan about:license on new tab
6. Click "Mozilla Public License" link on about:license

Actual Results:
Apear "Lanch Application"

Expected Results:
Jamp to Mozilla Public License(#mpl)

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix (for Miramar/Aurora)

This fixes both this and bug 659527.

I did a cut-down function so that we could use the specialTabs.aboutClickHandler, and made sure we'd covered all the links.

I tested the manual download link changes by replacing "noUpdatesFound" in onCheckComplete with "manualUpdate" and "downloadFailed".

Comment 2

[Jonathan Protzenko [:protz]]

Comment on attachment 537792 [details] [diff] [review]
The fix (for Miramar/Aurora)

Review of attachment 537792 [details] [diff] [review]:
-----------------------------------------------------------------

So I'm giving r- because I don't think it's such a good idea to go duplicating similar functions all over the place, but I'm willing to discuss this over IRC :-).

::: mail/base/content/aboutDialog.js
@@ +88,3 @@
>  #endif
>  }
>  

The function below basically copies everything from openContentTab: http://mxr.mozilla.org/comm-central/source/mail/base/content/utilityOverlay.js#231

Couldn't we just factor out the two into some common function that takes an third parameter that could be either { type: "about" } or { type: "content", regexp: theRegExp }...? I'm not that enthusiastic about happily duplicating code.

We could redirect both openAboutTab and openContentTab to be calls to third function with the right parameters.

::: mail/base/content/aboutDialog.xul
@@ +67,4 @@
>          >
>  
>    <script type="application/javascript" src="chrome://messenger/content/aboutDialog.js"/>
> + <script type="application/javascript" src="chrome://messenger/content/specialTabs.js"/>

Nit: this does not seem to be aligned.

Comment 3

[Jonathan Protzenko [:protz]]

Oh and I tested this of course and this fixes both this bug and bug 659527

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 537792 [details] [diff] [review]
The fix (for Miramar/Aurora)

I'm appealing ;-) I agree with re-using the function, but I think for Miramar, and possibly Aurora, I don't want to change that function definition in utilityOverlay. Whilst I suspect no add-ons are using it yet, I'd just prefer not to just in case.

Comment 5

[Jonathan Protzenko [:protz]]

Comment on attachment 537792 [details] [diff] [review]
The fix (for Miramar/Aurora)

Alright :-). Can you create a followup bug for factoring the two functions? You can assign to me if you wish.

Comment 6

[Mark Banner (:standard8)]

Filed bug 663112 on the follow-up.

Checked in: http://hg.mozilla.org/comm-central/rev/08be6ad1285b

Comment 7

[Mark Banner (:standard8)]

Checked into comm-miramar: http://hg.mozilla.org/releases/comm-miramar/rev/d29fdf070fe0

Comment 8

[baffclan]

Thanks for fixing this.

cannot reproduce with :
Shredder-20110611/WinVista, WinXP
Miramar-20110612/WinVista

Comment 9

[Mark Banner (:standard8)]

Checked into aurora: http://hg.mozilla.org/releases/comm-aurora/rev/45330ef6aa2a