Closed
Bug 660879
Opened 13 years ago
Closed 13 years ago
Create a temporary configure option to switch from the binary xpidl to pyxpidl
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
7.44 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I want to have pyxpidl in the tree side by side with the binary xpidl, so that I can unblock people who need pyxpidl but aren't that concerned about the build perf. A configure option seems like the easiest way to do this. This is 110% temporary.
Attachment #536332 -
Flags: review?(ted.mielczarek)
Comment 1•13 years ago
|
||
Comment on attachment 536332 [details] [diff] [review] Patch to add temporary configure option Review of attachment 536332 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +1876,5 @@ > fi > > dnl ======================================================== > +dnl xpidl - A temporary configure option for turning on pyxpidl > +dnl ======================================================== File a followup bug on removing this and mention the bug number here please? Too many temporary things live on forever. @@ +1889,5 @@ > + XPIDL_COMPILE='$(LIBXUL_DIST)/host/bin/host_xpidl$(HOST_BIN_SUFFIX)' > + else > + XPIDL_COMPILE='$(LIBXUL_DIST)/bin/xpidl$(BIN_SUFFIX)' > + fi > + XPIDL_COMPILE_HEADER="$XPIDL_COMPILE -m header -w \$(XPIDL_FLAGS) -o \$(XPIDL_GEN_DIR)/\$*" You can put these in single quotes to avoid bash eating your $s instead of escaping every single one.
Attachment #536332 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Don't think we'll need this.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•